501228 - topcrashers cron unsuccessful since 4/16/2009

Status: RESOLVED INVALID

(Socorro :: General, task)

Description

[Austin King [:ozten]]

startTopCrashers.py hasn't had a successful run since 4/16 in production.

This is due to build being NULL in some rows of the reports table.

I was able to repro in dev by setting build = NULL and running the script.

Expected:
Skip this row

Actual:
2009-06-29 15:07:58,746 CRITICAL - MainThread Caught Error: psycopg2.IntegrityError
2009-06-29 15:07:58,747 CRITICAL - null value in column "build" violates not-null constraint

2009-06-29 15:07:58,765 INFO - trace back follows:
  File "/home/aking/breakpad/socorro/socorro/cron/topcrashes.py", line 184, in calculateTopCrashes
    cur.execute(sql2, (signatureData['signature'], signatureData['version'], signatureData['product'], signatureData['build'], signatureData['total'], signatureData['win'], signatureData['mac'], signatureData['lin'], signatureData['rank'], last_rank, "", signatureData['uptime_average'], signatureData['users'], update_time))
  File "/usr/lib/python2.4/site-packages/psycopg2/extras.py", line 89, in execute
    return _cursor.execute(self, query, vars, async)

Comment 1

[Austin King [:ozten]]

Attachment: Adds check for null build value

Attached is a patch that fixes the issue. It rejects rows which have a NULL build value.

Comment 2

[Frank Griswold [:griswolf] [:fgriswold]]

Reviewed. Patch will work, in my opinion

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Austin - What's the status of this bug?