STR: 1. Log in as editor without admin privileges 2. Click "Editor Tools" to expand dropdown menu 3. Click "Performance" to open performance page AR: "Access denied." ER: Being able to view the performance page. Acceptable workaround: giving me admin privileges? ;o) Seriously though, Rey said on IRC that we should be able to see this, so, filing a bug to that effect. :-)
Yep I can confirm the above.
Created attachment 386349 [details] [diff] [review] Fix a simple typo This seems to work on my local machine. An editor can now access the performance page.
Comment on attachment 386349 [details] [diff] [review] Fix a simple typo R+ as this does fix the bug. Thanks! What concerns me are the checks against singular 'Editor' in several different controllers. That deserves some looking into.
Created attachment 390974 [details] [diff] [review] better patch I'm following Scott's lead on this and removing the check entirely.
Comment on attachment 390974 [details] [diff] [review] better patch Better indeed. Thanks!
Thanks again. r30534.
Verified FIXED on https://preview.addons.mozilla.org/en-US/editors/performance with user "s d <email@example.com", who was only a Developer/Editor when I tested.