If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Can't view Performance page as a non-admin editor

VERIFIED FIXED in 5.0.8

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: Gijs, Assigned: cesar)

Tracking

unspecified
5.0.8

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
STR:

1. Log in as editor without admin privileges
2. Click "Editor Tools" to expand dropdown menu
3. Click "Performance" to open performance page

AR:
"Access denied."

ER:
Being able to view the performance page.


Acceptable workaround: giving me admin privileges? ;o)

Seriously though, Rey said on IRC that we should be able to see this, so, filing a bug to that effect. :-)

Updated

8 years ago
Assignee: nobody → clouserw

Comment 1

8 years ago
Yep I can confirm the above.
Assignee: clouserw → nobody
Target Milestone: --- → 5.0.8
(Assignee)

Comment 2

8 years ago
Created attachment 386349 [details] [diff] [review]
Fix a simple typo

This seems to work on my local machine. An editor can now access the performance page.
Assignee: nobody → cdolivei.bugzilla
Status: NEW → ASSIGNED
Attachment #386349 - Flags: review?(smccammon)
Comment on attachment 386349 [details] [diff] [review]
Fix a simple typo

R+ as this does fix the bug. Thanks!

What concerns me are the checks against singular 'Editor' in several different controllers. That deserves some looking into.
Attachment #386349 - Flags: review?(smccammon) → review+
Whiteboard: [patch]
(Assignee)

Comment 4

8 years ago
Created attachment 390974 [details] [diff] [review]
better patch

I'm following Scott's lead on this and removing the check entirely.
Attachment #386349 - Attachment is obsolete: true
Attachment #390974 - Flags: review?(smccammon)
Comment on attachment 390974 [details] [diff] [review]
better patch

Better indeed. Thanks!
Attachment #390974 - Flags: review?(smccammon) → review+
(Assignee)

Comment 6

8 years ago
Thanks again. r30534.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: push-needed
Resolution: --- → FIXED
Whiteboard: [patch]
Verified FIXED on https://preview.addons.mozilla.org/en-US/editors/performance with user "s d <stephendonner@yahoo.com", who was only a Developer/Editor when I tested.
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.