501359 - add --with-crashreporter-enable-percent=10 to win32 release mozconfigs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[(not currently active) Ted Mielczarek]

bug 424960 added this to the tinderbox release mozconfigs, but it got lost along the way in the transition to buildbot/hg.

Comment 1

[Armen [:armenzg]]

Attachment: add --with-crashreporter-enable-percent=10 to win32 release mozconfigs

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 386027 [details] [diff] [review]
add --with-crashreporter-enable-percent=10 to win32 release mozconfigs 

Looks correct to me. I'll this in a few min.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 386027 [details] [diff] [review]
add --with-crashreporter-enable-percent=10 to win32 release mozconfigs 

changeset:   1278:2bcd35488ff0

Comment 4

[Samuel Sidler (old account; do not CC)]

Why did we decide on 10%? Does this still need to land on 1.9.1?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to comment #4)
> Why did we decide on 10%?

Dunno

> Does this still need to land on 1.9.1?

The original patch covers both branches.

Comment 6

[Samuel Sidler (old account; do not CC)]

(In reply to comment #5)
> The original patch covers both branches.

Clearing the blocking request then.

I kind of think it should be more like 25%, fwiw.

Comment 7

[(not currently active) Ted Mielczarek]

I kind of doubt it makes any difference.