50142 - [MARGIN-C]collapsing does positive/negative mix wrong

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  A collapsed margin, according to CSS1
http://www.w3.org/TR/REC-CSS1#vertical-formatting or CSS2
http://www.w3.org/TR/REC-CSS2/box.html#collapsing-margins , is the maximum of
the positive values plus the minimum of the negative values.  We don't do this
right, since MaxMargin collapses margins one at a time, which is wrong.

I have some of the necessary changes to correct this in my tree.  I'm not sure
if I'm going to finish or give up - it's a surprisingly large change because of
the organization of the block code (which I'm really beginning to hate).

STEPS TO REPRODUCE:
 * look at testcase

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Well, this is fixed in my tree

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Now it's broken again, in weird ways.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think maybe I've completely stopped pulling out top margins...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Giving margin collapsing bugs that I have not fixed back to buster.

Comment 6

[buster]

This is one we just can't get to before RTM.  Marking future.
Eric: since this is a css1 compliance issue, I thought you should be on the
cc-list.  Let me know if you disagree with "future" milestone.

Comment 7

[Hixie (not reading bugmail)]

Upon managerial request, adding the "testcase" keyword to 84 open layout bugs that
do not have the "testcase" keyword and yet have an attachement with the word
"test" in the description field. Apologies for any mistakes.

Comment 8

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking, since my changes on bug 86947 fix this.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed by checkin of bug 86947 at 2001-10-24 18:08 PDT.