Closed Bug 501574 Opened 11 years ago Closed 11 years ago

echo -n isn't portable (especially not to 10.5.x) so we get bogus creator codes

Categories

(MailNews Core :: Build Config, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch FixSplinter Review
Comm-central version of bug 501457 - on 10.4.x, "echo -n APPLMOZ_" would echo "APPLMOZ_" but on 10.5.x it echoes "-n APPLMOZ_" to foo.app/Contents/PkgInfo, making our creator code "-n A/PPLM".

Fun though the bugs where we do a trivial build config change to something everybody copy-pasted in the first place and do three separate reviews, I think we can really get away with just one here: I checked my last build of all three apps, they were all bogus, I patched it and rebuilt and all three were right.
Attachment #386211 - Flags: review?(bugzilla)
Comment on attachment 386211 [details] [diff] [review]
Fix

Yeah simple build config changes are fine. Must get the c-c build config team formalised sometime.
Attachment #386211 - Flags: review?(bugzilla) → review+
http://hg.mozilla.org/comm-central/rev/c8265ca33cec
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.