Closed Bug 501586 Opened 12 years ago Closed 12 years ago

Remove the last vestiges of MOZ_MILESTONE_RELEASE

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

rm
2.34 KB, patch
ted
: review+
Details | Diff | Splinter Review
Attached patch rm — — Splinter Review 
Back in the dark days of nsBuildID.h.in and mozBDate.pm, a normal official build would set MOZILLA_OFFICIAL, and wind up with <milestone>_<build id>, while a release would also set MOZ_MILESTONE_RELEASE and wind up with just <milestone>.

The dark days are gone, and there's nothing left that cares to have MOZ_MILESTONE_RELEASE ac_subst'ed, so it only serves to add to the confusion swirling around its neighbors, MOZILLA_OFFICIAL and BUILD_OFFICIAL.
Attachment #386222 - Flags: review?(ted.mielczarek)
Comment on attachment 386222 [details] [diff] [review]
rm

Maybe next you can get rid of one of MOZILLA_OFFICIAL/BUILD_OFFICIAL. :)
Attachment #386222 - Flags: review?(ted.mielczarek) → review+
/me ducks down the rathole of bug 435923...
http://hg.mozilla.org/mozilla-central/rev/8a925a0cd404
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Flags: in-testsuite-
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.