Closed
Bug 501586
Opened 15 years ago
Closed 15 years ago
Remove the last vestiges of MOZ_MILESTONE_RELEASE
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: philor, Assigned: philor)
References
Details
Attachments
(1 file)
|
2.34 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Back in the dark days of nsBuildID.h.in and mozBDate.pm, a normal official build would set MOZILLA_OFFICIAL, and wind up with <milestone>_<build id>, while a release would also set MOZ_MILESTONE_RELEASE and wind up with just <milestone>. The dark days are gone, and there's nothing left that cares to have MOZ_MILESTONE_RELEASE ac_subst'ed, so it only serves to add to the confusion swirling around its neighbors, MOZILLA_OFFICIAL and BUILD_OFFICIAL.
Attachment #386222 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 386222 [details] [diff] [review] rm Maybe next you can get rid of one of MOZILLA_OFFICIAL/BUILD_OFFICIAL. :)
Attachment #386222 -
Flags: review?(ted.mielczarek) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
/me ducks down the rathole of bug 435923...
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8a925a0cd404
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
||
Updated•14 years ago
|
Flags: in-testsuite-
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•