501630 - OpenSolaris x86 support

Status: RESOLVED FIXED

(Cloud Services :: General, enhancement)

Description

[Gary Gendel]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5 (.NET CLR 3.5.30729)
Build Identifier: Weave 0.4.0

Each time Weave is automatically updated it is missing OpenSolaris as a platform.

I've been supplying Weave for Firefox on OpenSolaris x86.  This means that I modified the Makefiles to build the WeaveCrypto.so component and include it in the Weave installer, and make it available externally from the normal channels.

I'd like to push my Makefile changes back and provide a prebuilt WeaveCrypto.so package for the build system so OpenSolaris is supported.

Reproducible: Always

Steps to Reproduce:
1. On OpenSolaris with Firefox 3.5 install the Weave plugin
2. Weave won't install
3. Install my latest version from http://www.genashor.com/mozilla
4. Viola!



As I understand it, you already have pre-built Weave components for Fennec, Windows, etc. used during the build process.  I'd like to make OpenSolaris x86 one of those.

Comment 1

[Ed Lee :Mardak]

Gary: Could you provide a patch for the Makefile changes to get weave crypto to build on SunOS i86pc?

Also curious, did you build your own xulrunner sdk?

Comment 2

[Gary Gendel]

Attachment: The Makefile modified for OpenSolaris

Ed, This is the Makefile with the changes for OpenSolaris in the crypto/src directory.  I did build my own xulrunner using the directions in the wiki.

Gary

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/03a6fdcf2cb5
Add SunOS for crypto Makefile to build a dynamic shared library. 

http://hg.mozilla.org/labs/weave/rev/4cd08d986c78
Add i86pc machine detection for crypto Makefile. Add SunOS for test Makefiles. 

http://hg.mozilla.org/labs/weave/rev/c796c36ce878
Generate SunOS x86 binaries and put them under platform/SunOS because the contrib Firefox builds are SunOS_x86-sunc while we build SunOS_x86-cc. 

Thanks for the Makefile Gary. I also updated the other test makefiles and everything seems to pass for me, and Weave is able to sync with my other machines.

I did have to put the binary under platform/SunOS instead of platform/SunOS_x86-cc. The contributed 3.5.1 build has an XPCOMABI of x86-sunc. So I suppose I could have put the file there instead of just SunOS...

Comment 4

[Dan Mills [:thunder]]

(In reply to comment #3)

> I did have to put the binary under platform/SunOS instead of
> platform/SunOS_x86-cc. The contributed 3.5.1 build has an XPCOMABI of x86-sunc.
> So I suppose I could have put the file there instead of just SunOS...

SunOS still supports SPARC, no?  Your binary will not load on SPARC machines ;-)

Comment 5

[Ed Lee :Mardak]

Yeah, I spent quite some time trying to debug why sometimes the binary component loaded and other times not.. I wasn't sure if it was because I was using cc instead of suncc, but I couldn't get sunc. And then I tried putting it as SunOS_x86 instead of SunOS_x86-cc or SunOS_x86-suncc but apparently the XPCOMABI check is for the whole thing, SunOS_x86-sunc.

Just checking, Gary, you didn't compile binaries for SPARC did you?

I do see contrib 3.5* builds that are opensolaris-i386 as well as opensolaris-sparc (and solaris10).. but I'm not sure if I want to try cross compiling right now ;)