Closed Bug 501720 Opened 15 years ago Closed 15 years ago

Mobile: Weave pages

Categories

(www.mozilla.org :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 513312

People

(Reporter: davedash, Assigned: davedash)

References

()

Details

Attachments

(3 files, 2 obsolete files)

Pages for Weave and Mobile
Attached patch v1 (obsolete) — Splinter Review
Images to come!
Assignee: nobody → dd
Status: NEW → ASSIGNED
Attachment #387277 - Flags: review?(rdoherty)
Attached file images (obsolete) —
Comment on attachment 387277 [details] [diff] [review]
v1

Looks pretty good, a few small issues.

All the quotes show up as '?' to me for some weird reason (copying from a Word file does that to me).

I'm also seeing the shadows get cut off. (will attach screenshot)
Attachment #387277 - Flags: review?(rdoherty) → review-
Attached image clipped shadows
Attached patch v2Splinter Review
Attachment #387277 - Attachment is obsolete: true
Attachment #387334 - Flags: review?(rdoherty)
Attached file images v2
Attachment #387282 - Attachment is obsolete: true
Attachment #387335 - Flags: review?(rdoherty)
Attachment #387334 - Flags: review?(rdoherty) → review+
Comment on attachment 387334 [details] [diff] [review]
v2

Looks good. One typo:

Save keystrokes by signing in to all your favorite sitesusing saved passwords.

'sitesusing' should be 'sites using'
Attachment #387335 - Flags: review?(rdoherty)
Committing to https://svn.mozilla.org/projects/mozilla.com/trunk ...
	M	en-US/mobile/faq.html
	A	en-US/mobile/weave.html
Committed r29651
	M	en-US/mobile/faq.html
	A	en-US/mobile/weave.html
r29651 = ff715d3ab1eff33ef74827e3f2511f1ed7ca6274 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
en-US/mobile/weave.html: locally modified
includes/functions.inc.php: locally modified
style/tignish/mobile.css: locally modified
	M	en-US/mobile/weave.html
	A	img/mobile/purple-button-arrow.png
	A	img/mobile/rounded-background-med.png
	A	img/mobile/weave-phone.png
	M	style/tignish/mobile.css
Committed r29652
	A	img/mobile/purple-button-arrow.png
	A	img/mobile/weave-phone.png
	A	img/mobile/rounded-background-med.png
	M	en-US/mobile/weave.html
	M	style/tignish/mobile.css
r29652 = 0f722c1ab8034c27a7c6d869de13cb423e76360c (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
en-US/mobile/weave.html: locally modified
img/mobile/purple-button-arrow.png: locally modified
img/mobile/rounded-background-med.png: locally modified
includes/functions.inc.php: locally modified
style/tignish/mobile.css: locally modified
	M	en-US/mobile/weave.html
	A	img/mobile/flag-spiff-bg.png
	A	img/mobile/stripes.png
	M	style/tignish/mobile.css
Committed r29653
	A	img/mobile/flag-spiff-bg.png
	A	img/mobile/stripes.png
	M	en-US/mobile/weave.html
	M	style/tignish/mobile.css
r29653 = 44223c94d0b9d8db427a795fc7059027cb6d38b7 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
en-US/mobile/weave.html: locally modified
img/mobile/purple-button-arrow.png: locally modified
img/mobile/rounded-background-med.png: locally modified
includes/functions.inc.php: locally modified
style/tignish/mobile.css: locally modified
	M	img/mobile/purple-button-arrow.png
	M	img/mobile/rounded-background-med.png
	M	style/tignish/mobile.css
Committed r29654
	M	img/mobile/purple-button-arrow.png
	M	img/mobile/rounded-background-med.png
	M	style/tignish/mobile.css
r29654 = 698e3c7b0f0f0bef66bceb1c3cc49eec294d9ec1 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
en-US/mobile/weave.html: locally modified
includes/functions.inc.php: locally modified
	M	en-US/mobile/weave.html
Committed r29655
	M	en-US/mobile/weave.html
r29655 = 471d87a3dfa4c8d87e8a2b4f001010365e361f7f (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
en-US/mobile/weave.html: locally modified
includes/functions.inc.php: locally modified
	M	en-US/mobile/weave.html
	M	includes/functions.inc.php
Committed r29656
	M	includes/functions.inc.php
	M	en-US/mobile/weave.html
r29656 = 15b75b4695d47b926674eae581cc9ba6a8c9584c (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
1) Mock has "Note that Weave must also be installed on your phone." in italics.
2) How will "Get the Weave Add-on Now" be populated?  Will it use product-details?
3) Mock has it wrong, too, but "the Weave lets your phone..." probably should say "the Weave add-ons lets your phone..."
4) Does this page (and the rest of the new Mobile pages) need WAI-ARIA support?  I ask because the page validates, which is a clear sign it probably doesn't have it :-)
5) The links to Fennec and Firefox are "http://mozilla.com/mobile" and "http://firefox.com" -- they should probably use the "www." hostname-prefix (convention)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
#2 - Not sure if product-details is the best way to do the Weave add-on info. Will have to think about it.

#4 - I'm not expecting/requiring ARIA support yet.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → WONTFIX
Resolution: WONTFIX → DUPLICATE
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: