Closed Bug 501746 Opened 13 years ago Closed 13 years ago

nsChildView::DispatchEvent() has a stack nsCOMPtr that needs a QueryInterface call

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: nick.kreeger, Assigned: nick.kreeger)

Details

Attachments

(1 file)

While I was running with a debug XULRunner - I kept getting this warning logged in my console:

QueryInterface needed:..... (whatev)

I tracked this down and found that inside of |DispatchEvent()| a grip is put on either |mParentWidget| (which is fine) and |this| (which is the problem).

I have a one line patch to fix this.
Attached patch Patch V1Splinter Review
Here is my proposed patch.
Assignee: nobody → nick.kreeger
Status: NEW → ASSIGNED
Attachment #386317 - Flags: review?
Attachment #386317 - Flags: review? → review+
Pushed to mozilla-central. Thanks Josh!

changeset:   29938:0d648609ce81
user:        Nick Kreeger <nick.kreeger@park.edu>
date:        Wed Jul 01 11:41:34 2009 -0700
summary:     Fixing bug 501746 - nsChildView::DispatchEvent() has a stack nsCOMPtr that needs a QueryInterface call.

changeset:   29943:ea19cebaa1ef
tag:         tip
parent:      29938:0d648609ce81
parent:      29942:b15a28eeed13
user:        Nick Kreeger <nick.kreeger@park.edu>
date:        Wed Jul 01 11:45:18 2009 -0700
summary:     Merging for checkin of bug 501746
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: Widget: Mac → Widget: Cocoa
QA Contact: mac → cocoa
You need to log in before you can comment on or make changes to this bug.