fold nsIPluginInstanceInternal into nsIPluginInstance

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

({dev-doc-complete})

Trunk
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

20.56 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 386356 [details] [diff] [review]
fix v1.0

We should remove nsIPluginInstanceInternal, fold it into nsIPluginInstance.
Attachment #386356 - Flags: superreview?(jst)
(Assignee)

Comment 1

9 years ago
Johnny - I'm particularly interested in what you have to say about "nsHTMLPluginObjElementSH::NewResolve". Seems like we can remove a lot of that.
Comment on attachment 386356 [details] [diff] [review]
fix v1.0

PluginWndProc() (in nsPluginNativeWindowWin.cpp):

+    if (inst && !nsVersionOK(inst->GetPluginAPIVersion(), NP_POPUP_API_VERSION))

That doesn't compile, needs to be something like:

    PRUint16 version;
    inst->GetPluginAPIVersion(&version);

    if (inst && !nsVersionOK(version, NP_POPUP_API_VERSION))
      inst->PushPopupsEnabledState(PR_TRUE);

r+sr=jst
Attachment #386356 - Flags: superreview?(jst)
Attachment #386356 - Flags: superreview+
Attachment #386356 - Flags: review+
(Assignee)

Comment 3

9 years ago
Created attachment 386421 [details] [diff] [review]
fix v1.1

Windows build fix, update to current trunk.
Attachment #386356 - Attachment is obsolete: true
(Assignee)

Comment 4

9 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/d100ce57eb76
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Updated

9 years ago
Summary: remove nsIPluginInstanceInternal → fold nsIPluginInstanceInternal into nsIPluginInstance
You need to log in before you can comment on or make changes to this bug.