Created attachment 386356 [details] [diff] [review] fix v1.0 We should remove nsIPluginInstanceInternal, fold it into nsIPluginInstance.
Johnny - I'm particularly interested in what you have to say about "nsHTMLPluginObjElementSH::NewResolve". Seems like we can remove a lot of that.
Comment on attachment 386356 [details] [diff] [review] fix v1.0 PluginWndProc() (in nsPluginNativeWindowWin.cpp): + if (inst && !nsVersionOK(inst->GetPluginAPIVersion(), NP_POPUP_API_VERSION)) That doesn't compile, needs to be something like: PRUint16 version; inst->GetPluginAPIVersion(&version); if (inst && !nsVersionOK(version, NP_POPUP_API_VERSION)) inst->PushPopupsEnabledState(PR_TRUE); r+sr=jst
Created attachment 386421 [details] [diff] [review] fix v1.1 Windows build fix, update to current trunk.
Attachment #386356 - Attachment is obsolete: true
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/d100ce57eb76
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Summary: remove nsIPluginInstanceInternal → fold nsIPluginInstanceInternal into nsIPluginInstance
You need to log in before you can comment on or make changes to this bug.