Closed Bug 501786 Opened 13 years ago Closed 13 years ago

fold nsIPluginInstanceInternal into nsIPluginInstance

Categories

(Core :: Plug-ins, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
We should remove nsIPluginInstanceInternal, fold it into nsIPluginInstance.
Attachment #386356 - Flags: superreview?(jst)
Johnny - I'm particularly interested in what you have to say about "nsHTMLPluginObjElementSH::NewResolve". Seems like we can remove a lot of that.
Comment on attachment 386356 [details] [diff] [review]
fix v1.0

PluginWndProc() (in nsPluginNativeWindowWin.cpp):

+    if (inst && !nsVersionOK(inst->GetPluginAPIVersion(), NP_POPUP_API_VERSION))

That doesn't compile, needs to be something like:

    PRUint16 version;
    inst->GetPluginAPIVersion(&version);

    if (inst && !nsVersionOK(version, NP_POPUP_API_VERSION))
      inst->PushPopupsEnabledState(PR_TRUE);

r+sr=jst
Attachment #386356 - Flags: superreview?(jst)
Attachment #386356 - Flags: superreview+
Attachment #386356 - Flags: review+
Attached patch fix v1.1Splinter Review
Windows build fix, update to current trunk.
Attachment #386356 - Attachment is obsolete: true
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/d100ce57eb76
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: remove nsIPluginInstanceInternal → fold nsIPluginInstanceInternal into nsIPluginInstance
You need to log in before you can comment on or make changes to this bug.