Editor logs can not be viewed by a non-admin editor

VERIFIED FIXED in 5.0.8

Status

defect
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: smccammon, Assigned: smccammon)

Tracking

unspecified
5.0.8

Details

(Whiteboard: [patch], )

Attachments

(1 attachment)

Assignee

Description

10 years ago
This appears to be the same permission problem as in bug 500111.
Everything in /editors should be accessible to all editors. If you're saying that normal editors can see /editors/logs, that is intentional.
Assignee

Comment 2

10 years ago
> Everything in /editors should be accessible to all editors. If you're saying
> that normal editors can see /editors/logs, that is intentional.

Yes, that is the correct behavior. However the current behavior is that the logs are only viewable by admins due to a similar broken permission check in the referenced bug.
Sorry, I somehow missed the "not" in the bug summary.
Assignee

Comment 4

10 years ago
Posted patch FixSplinter Review
Default permission checks do seem to be in affect on the editors controller, so these explicit checks are not necessary.
Assignee: nobody → smccammon
Status: NEW → ASSIGNED
Attachment #386399 - Flags: review?(clouserw)
Attachment #386399 - Flags: review?(clouserw) → review+
Comment on attachment 386399 [details] [diff] [review]
Fix

Please hold off committing until 5.0.8
Whiteboard: [patch]
Target Milestone: 5.0.7 → 5.0.8
Assignee

Comment 6

10 years ago
Fixed in r30066
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Verified Fixed on preview.addons.mozilla.org
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.