501815 - All drop types are valid for Flash content

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Nochum Sossonko [:Natch]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5

STR:

1) Go to any youtube video (eg http://www.youtube.com/watch?v=hpkitLUbeEg ).
2) drag *anything* (picture, selected text, etc.) over the video.
3) The cursor changes to the drop-allowed cursor.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

this regressed between 20080901021304 & 20080902021221 => http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-09-01+02%3A13&enddate=2008-09-02+02%3A12
likely caused by Bug 452083.

Comment 2

[Neil Deakin]

Attachment: set effectAllowed to none for plugins

Tested and cancels a drop properly. A java plugin that accepts file drops at http://upload.thinfile.com/upload/demo.php still functions.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 395606 [details] [diff] [review]
set effectAllowed to none for plugins

>   if (mInstance) {
>     nsCOMPtr<nsIDOMDragEvent> dragEvent = do_QueryInterface(aEvent);
>     if (dragEvent) {
>+      nsAutoString eventType;
>+      aEvent->GetType(eventType);
>+      if (eventType.EqualsLiteral("dragenter") || eventType.EqualsLiteral("dragover")) {
>+        // set the allowed effect to none here. The plugin should set it if necessary
>+        nsCOMPtr<nsIDOMDataTransfer> dataTransfer;
>+        dragEvent->GetDataTransfer(getter_AddRefs(dataTransfer));
>+        dataTransfer->SetEffectAllowed(NS_LITERAL_STRING("none"));
Add a null check for dataTransfer.

I think the method should also check that event is trusted.

Comment 4

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/4ee238eba089

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Neil, do we want this on 1.9.2? If so, can you put a patch up for approval?

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 395606 [details] [diff] [review]
set effectAllowed to none for plugins

Didn't make 1.9.2.2, but wanted for 1.9.2.3

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 395606 [details] [diff] [review]
set effectAllowed to none for plugins

Unfortunately will have to minus because this doesn't match the check-in -- we've found too many times people back-port patches from bugs rather than the changeset. Please request approval on an updated patch that includes Olli's review comments.