501945 - Should treat nightly testers as Firefox 3.5 users for purpose of ad badges

Status: RESOLVED WONTFIX

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Henri Sivonen (:hsivonen)]

Steps to reproduce:

 1) Load http://www.spreadfirefox.com/affiliates/utw in a trunk nightly, self built Minefield or a tryserver build.

Actual results:
"You are settling for good when there is awesome."

Expected results.
"You rock."

Comment 1

[Matthew N. [:MattN]]

I agree that this is misleading for nightly testers.  Maybe we could show the Firefox 3.5 banner to anyone with a Firefox version >= 3.5?

Comment 2

[Matthew N. [:MattN]]

Attachment: Treat Minefield and Firefox betas more appropriately

Simple patch that checks that the version of Firefox or Minefield is >= the desired version for the badge.

Comment 3

[Mary]

Hey there:  I think Sam is out this week.  Buchanan:  Is this something you can help with?

Mary

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 466231 [details] [diff] [review]
Treat Minefield and Firefox betas more appropriately

Removing review request since the new affiliate website https://affiliates.mozilla.org) seems to just use images.

Comment 5

[:Cykesiopka]

The current affiliate website doesn't even seem to mention a Firefox version... Is this bug still valid...?

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to Cykesiopka from comment #5)
> The current affiliate website doesn't even seem to mention a Firefox
> version... Is this bug still valid...?

Unclear, since I don't have the ancient Firefox affiliate image URLs at hand, so I can't check what images they serve now. 

(Sites out there could still include those images. I got rid of the image on my site, when it became too embarrassing that the Mozilla side serving those images wasn't being maintained appropriately in the light of Rapid Release.)

Comment 7

[Henri Sivonen (:hsivonen)]

Effectively WONTFIXed since graveyarded.