501983 - 404 pages should not list articles in other locales

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

Go to http://support-stage.mozilla.org/en-US/kb/Cannot+log+in+to+websitess
The list of recommended articles includes many articles in other locales. It should only list articles that are in the language of the locale in the URL.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This might go up to Tiki too.

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: patch, v2

Actually, it would be better to check locale is set before passing it.

Comment 3

[Paul Craciunoiu [:paulc]]

r48835 / r48836.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://support-stage.mozilla.org/en-US/kb/Cannot+log+in+to+websitess; viewed source so I could check the locales easier :-)

Comment 5

[Paul Craciunoiu [:paulc]]

Marc: is this fixed in latest Tiki?

Comment 6

[Louis-Philippe Huberdeau]

Check of $_REQUEST['locale'] in the lib is not really nice. Plus, that variable is specific to the SUMO rewrite rules.

I'm also not convinced this is desired in all cases.

Comment 7

[Paul Craciunoiu [:paulc]]

Admittedly the fix wasn't a nice one. Sorry about that.

A better solution is to add an option for filtering by locale, and passing that in when issuing the 404 for pages.

The larger scope of this is also discussed in other bugs, but the functionality we want for SUMO is to be able to have pages with the same title in different locales -- as such, case tying <locale,page title> together is desired in all cases.