If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

404 pages should not list articles in other locales

VERIFIED FIXED in 1.3

Status

support.mozilla.org
Knowledge Base Software
--
minor
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: cilias, Assigned: paulc)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tiki_bug, tiki_upstreamed, URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Go to http://support-stage.mozilla.org/en-US/kb/Cannot+log+in+to+websitess
The list of recommended articles includes many articles in other locales. It should only list articles that are in the language of the locale in the URL.
(Assignee)

Updated

8 years ago
Assignee: nobody → paul.craciunoiu
Severity: normal → minor
(Assignee)

Comment 1

8 years ago
Created attachment 386549 [details] [diff] [review]
patch, v1

This might go up to Tiki too.
Attachment #386549 - Flags: review?(smirkingsisyphus)
Attachment #386549 - Flags: review?(laura)

Updated

8 years ago
Attachment #386549 - Flags: review?(laura) → review+
(Assignee)

Updated

8 years ago
Attachment #386549 - Flags: review?(smirkingsisyphus)
(Assignee)

Comment 2

8 years ago
Created attachment 391415 [details] [diff] [review]
patch, v2

Actually, it would be better to check locale is set before passing it.
Attachment #386549 - Attachment is obsolete: true
Attachment #391415 - Flags: review?(laura)

Updated

8 years ago
Attachment #391415 - Flags: review?(laura) → review+
(Assignee)

Comment 3

8 years ago
r48835 / r48836.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Verified FIXED on http://support-stage.mozilla.org/en-US/kb/Cannot+log+in+to+websitess; viewed source so I could check the locales easier :-)
Status: RESOLVED → VERIFIED
(Assignee)

Comment 5

8 years ago
Marc: is this fixed in latest Tiki?
Whiteboard: tiki_bug
Check of $_REQUEST['locale'] in the lib is not really nice. Plus, that variable is specific to the SUMO rewrite rules.

I'm also not convinced this is desired in all cases.
Whiteboard: tiki_bug → tiki_bug, tiki_discuss
(Assignee)

Comment 7

8 years ago
Admittedly the fix wasn't a nice one. Sorry about that.

A better solution is to add an option for filtering by locale, and passing that in when issuing the 404 for pages.

The larger scope of this is also discussed in other bugs, but the functionality we want for SUMO is to be able to have pages with the same title in different locales -- as such, case tying <locale,page title> together is desired in all cases.
Whiteboard: tiki_bug, tiki_discuss → tiki_bug, tiki_upstreamed
You need to log in before you can comment on or make changes to this bug.