502065 - resize fennec when software keyboard is displayed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

currently we send a notification out when the software keyboard is displayed.  This is so that xul applications can resize such that the keyboard does not overlap their content.

The notification is created here:

http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindowCE.cpp#90

The toolkit common dialogs already support this handling:

http://mxr.mozilla.org/mozilla-central/source/toolkit/content/commonDialog.js#117

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Each potential UI element that needs to be resized will have to be handled, possibly, separately.

Simply resizing the main window won't actually make everything better

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I see similar problems while looking for a url in the awesomebar and the keyboard covers the bottom results.  I cannot pan the awesomebar results causing confusion

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch is a basic resize patch. It only resizes the main window, which will cause any "resize-aware" UI to update accordingly.

The patch also changes the "const gXxx" style used to FF for some observers to the Fennec "var Xxx" style.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

The patch does change the awesombar, for example, on the n810 using a softkb.

However, while it does resize the window when focusing a content textbox, the textbox could be off-screen. File those and other related issues as separate bugs please.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

See bug 479444 for adjusting textbox location when sofkb is visible

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 389496 [details] [diff] [review]
patch

I think I would prefer not renaming the global objects that were copied over from FF (even if their implementations have diverged a little), as discussed on IRC.

Since this code is only needed on WinCE, I think it's probably a good idea to put behind an #ifdef WINCE.

Also need to remove the Components.utils.reportError :)

r=me with that.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> (From update of attachment 389496 [details] [diff] [review])
> I think I would prefer not renaming the global objects that were copied over
> from FF (even if their implementations have diverged a little), as discussed on
> IRC.

OK.. for now :)

> Since this code is only needed on WinCE, I think it's probably a good idea to
> put behind an #ifdef WINCE.

Done
 
> Also need to remove the Components.utils.reportError :)

Done

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/ffafecad14a1

Comment 9

[Aakash Desai [:aakashd]]

It's resized on the Omnia, but there's space between the quicklinks bar and the soft keyboard using:

Build Id: Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a1pre)
Gecko/20090803 Fennec/1.0a3pre

I'm marking this as re-opened.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #9)
> It's resized on the Omnia, but there's space between the quicklinks bar and the
> soft keyboard using:
> 
> Build Id: Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a1pre)
> Gecko/20090803 Fennec/1.0a3pre
> 
> I'm marking this as re-opened.

bug 505210

closing again

Comment 11

[Aakash Desai [:aakashd]]

Not minding the issue in the bug referenced in comment #10; this is working on my htc touch pro and omnia using build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090817 Fennec/1.0a3pre