502087 - Audit and make optional any SUMO-specific dependencies

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[E. Cooper [:ecooper]]

As part of the productization of SUMO we need to go through the codebase and make optional any features/software we use that may not be present on each user's machine. 

Things like Sphinx and memcached (and minify using memcache) are good examples of what we need to look for.

Comment 1

[E. Cooper [:ecooper]]

How do we want to approach Sphinx for this? I was going to create a bug, but then realized it's something we could just leave out of the package all together.

Comment 2

[E. Cooper [:ecooper]]

(In reply to comment #1)
> How do we want to approach Sphinx for this? I was going to create a bug, but
> then realized it's something we could just leave out of the package all
> together.

Same goes for the PAGELIST plugin and tables (feature that powers the l10n status pages, most popular support articles, etc). Do we want an admin panel to add/remove pages or remove it from the package?

Comment 3

[Laura Thomson :laura]

(In reply to comment #1)
> How do we want to approach Sphinx for this? I was going to create a bug, but
> then realized it's something we could just leave out of the package all
> together.

We already have the admin panel for enable/disable newsearch.  That panel needs CSS and linking into the main admin panel (under features???).  We also need the docs on how to install it (where's that bug gone) if users decide to use it).

Comment 4

[Laura Thomson :laura]

(In reply to comment #2)
> (In reply to comment #1)
> > How do we want to approach Sphinx for this? I was going to create a bug, but
> > then realized it's something we could just leave out of the package all
> > together.
> 
> Same goes for the PAGELIST plugin and tables (feature that powers the l10n
> status pages, most popular support articles, etc). Do we want an admin panel to
> add/remove pages or remove it from the package?

It seems like a valuable feature, so add an admin panel.

Comment 5

[E. Cooper [:ecooper]]

Somehow this slipped my mind, but the metrics dashboard? Is this something we will be going the Live Chat route with this? Or are we going to try to make it p10n friendly?

Comment 6

[Paul Craciunoiu [:paulc]]

I'd say the metrics dashboard isn't too important for p10n yet, or at least I think we could postpone p10n-ing it. At any rate, I can do that fairly easily, there's not much code to change (if any).

Comment 7

[[:Cww]]

The PAGELIST feature relies on sumotools and outside data.  I'm assuming I'm not on the hook for providing those parts.

Comment 8

[Paul Craciunoiu [:paulc]]

While auditing this, I spawned bug 510101.
Looking at comments.php and tiki-view_forum.tpl - a lot of comment status functionality is hard coded.

Comment 9

[Paul Craciunoiu [:paulc]]

(In reply to comment #6)
> I'd say the metrics dashboard isn't too important for p10n yet, or at least I
> think we could postpone p10n-ing it. At any rate, I can do that fairly easily,
> there's not much code to change (if any).
Roger that. I've investigated this, and I don't see any specific Firefox code - not even Mozilla specific. So it's good to go for p12n.

Comment 10

[Paul Craciunoiu [:paulc]]

James and I walked through the code and audited all files that have changed in the past 9 months, this should take care of most of our problems.
Auditing all files changed >9 months ago requires too many work-hours. We'll find problems as they arise, but odds are they'll be minor.

I also searched the code for: firefox, mozilla, fx and made sure all those instances are not hard coded.

This should be marked fixed once all its dependencies are covered.