Closed
Bug 502228
Opened 16 years ago
Closed 16 years ago
Edit about: page
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
VERIFIED
WONTFIX
People
(Reporter: viper550, Assigned: tdowner)
Details
Attachments
(1 file)
2.43 KB,
patch
|
Pike
:
review-
gerv
:
ui-review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
We have the about: page, and the Help>About link leads to a completely different dialog. If anything, we should keep just the About: page.
And then, the about page itself, should be structured a bit differently, saying something like:
[Logo]
Version 3.5. Built [built date]
[user agent]
Mozilla Firefox is (link)free and open software(/link) from the non-profit Mozilla Foundation and its many (LINK)contributors(/LINK).
See the (link)build configuration(/link) used for this version.
Read the (link)licensing information(/LINK) for this product and its components
Firefox® is a registered trademark of the Mozilla Foundation, use of these marks are regulated by the (link)Mozilla trademark guidelines(/link)
---
The "regular" about box doesn't make our openness clear enough, this would make it a bit more clear what is going on here.
Reproducible: Always
Assignee | ||
Comment 1•16 years ago
|
||
The about: page is not found easily by most people. The majority of users do not know about the whole about: thing (about:crashes, about:, about:mozilla, etc.). While we could do like Seamonkey, and clicking on About go to the About page, it is a very clunky way of doing it, while the About dialog is a lightweight way to show what version you are running, which is all that is needed. Your issue about restructuring the about: page could be valid though.
Summary: Why do we have two about boxes? → Edit about: page
Whiteboard: wontfix?
Version: unspecified → Trunk
Assignee | ||
Comment 2•16 years ago
|
||
Well, I think reformatting the about page could make some sense, so taking for now.
Assignee: nobody → tyler.downer
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: wontfix?
Assignee | ||
Comment 3•16 years ago
|
||
I think this makes it a little better. See what benjamin thinks.
Attachment #387055 -
Flags: review?(benjamin)
Comment 4•16 years ago
|
||
Comment on attachment 387055 [details] [diff] [review]
Patch v1
Axel should review l10n impact here, and gerv should do UI review. I'm not convinced we need this on the about: page since that's mainly a licensing information page.
I will note that splitting the sentence up the way you've done it is probably not kosher for l10n, but I don't know the "right way" to do it.
Attachment #387055 -
Flags: ui-review?(gerv)
Attachment #387055 -
Flags: review?(l10n)
Attachment #387055 -
Flags: review?(benjamin)
Comment 5•16 years ago
|
||
Comment on attachment 387055 [details] [diff] [review]
Patch v1
That page is in a sad state from an l10n perspective. It has a load of hardcoded spaces, and this patch adds more. Not that I think it's worth the hassle of fixing that.
The patch will break, as about.open.afterLink isn't defined. "Mozilla" should probably not be hard-coded, at least it's not in about:rights. The change to about.license.afterLink is rather unmotivated, so its unclear if it'd warrant an entity name change or not.
I personally don't think this change is necessary, but this is Gerv's call.
Attachment #387055 -
Flags: review?(l10n) → review-
Comment 6•16 years ago
|
||
Comment on attachment 387055 [details] [diff] [review]
Patch v1
Thank you very much, but I don't think this is quite the right way to go. We need to sort out the relationship between about:, about:rights and about:licence, but until we do, let's let sleeping dogs lie.
Gerv
Attachment #387055 -
Flags: ui-review?(gerv) → ui-review-
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•