Closed Bug 502241 Opened 15 years ago Closed 15 years ago

TM: icc warnings in jsopcode.cpp

Categories

(Core :: JavaScript Engine, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

These look non-bogus to me.

../jsopcode.cpp(5365): warning #186: pointless comparison of unsigned integer with zero
              if (tmp_pcdepth >= 0) {
                              ^

../jsopcode.cpp(5381): warning #186: pointless comparison of unsigned integer with zero
      LOCAL_ASSERT(pcdepth >= 0);
      ^

../jsopcode.cpp(5407): warning #186: pointless comparison of unsigned integer with zero
      if (pcdepth < 0)
Attached patch patchSplinter Review
Assignee: general → gal
Attachment #386757 - Flags: review?(brendan)
Comment on attachment 386757 [details] [diff] [review]
patch

r=me.

/be
Attachment #386757 - Flags: review?(brendan) → review+
http://hg.mozilla.org/tracemonkey/rev/e8bfda69fbd8
Priority: -- → P2
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/e8bfda69fbd8
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: