502251 - Add--[no-]truncate switch to contrib/recode.pl

Status: ASSIGNED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[David D. Kilzer (ddk)]

Attachment: Patch

* SUMMARY
While testing the upgrade of <https://bugs.webkit.org/>, I found that the output from the --show-failures switch wasn't very helpful if the "bad" characters were truncated in the output.

Adding a --[no-]truncate switch (that defaults to truncating--the current behavior) was a big help in creating the overrides file for the upgrade.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 386742 [details] [diff] [review]
Patch

>diff --git a/BugsSite/contrib/recode.pl b/BugsSite/contrib/recode.pl
>+  --[no-]truncate  Truncate from/to string output (default: yes).

  Looks good, but this text needs to be made more specific, on checkin. I can do that.

Comment 2

[David D. Kilzer (ddk)]

(In reply to comment #1)
> (From update of attachment 386742 [details] [diff] [review])
> >diff --git a/BugsSite/contrib/recode.pl b/BugsSite/contrib/recode.pl
> >+  --[no-]truncate  Truncate from/to string output (default: yes).
> 
>   Looks good, but this text needs to be made more specific, on checkin. I can
> do that.

Great!  Thanks!  (My commit access was revoked many years ago. :)

Comment 3

[Max Kanat-Alexander]

Comment on attachment 386742 [details] [diff] [review]
Patch

Ah, on testing, I realized that this makes the default help output too long for a 25-line terminal, and I'd really like to keep it short enough, since this is such a simple script. If you have a solution to that problem, feel free to post it in another patch.

Comment 4

[David D. Kilzer (ddk)]

(In reply to comment #3)
> (From update of attachment 386742 [details] [diff] [review])
> Ah, on testing, I realized that this makes the default help output too long for
> a 25-line terminal, and I'd really like to keep it short enough, since this is
> such a simple script. If you have a solution to that problem, feel free to post
> it in another patch.

I'm not sure what you mean?  When I run "./contrib/recode.pl --help", the "Usage:" and "Options:" output is 68 lines total.  If you pipe through "less", there are 24 lines from "Usage:" to the blank line before "Options:".

Comment 5

[Max Kanat-Alexander]

ddk: run just contrib/recode.pl without any arguments.

Comment 6

[Frédéric Buclin]

Bugzilla 3.2 and 3.4 are closed for enhancement requests.

Comment 7

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.