502296 - TM: warnings in jsxdrapi.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Andreas Gal :gal]

../jsxdrapi.cpp: In function ‘JSBool JS_XDRDouble(JSXDRState*, jsdouble**)’:
../jsxdrapi.cpp:508: warning: ‘d’ may be used uninitialized in this function
../jsxdrapi.cpp: In function ‘JSBool XDRValueBody(JSXDRState*, uint32, jsval*)’:
../jsxdrapi.cpp:508: warning: ‘d’ may be used uninitialized in this function
../jsxdrapi.cpp:547: warning: ‘dp’ may be used uninitialized in this function
../jsxdrapi.cpp: In function ‘JSBool js_XDRAtom(JSXDRState*, JSAtom**)’:
../jsxdrapi.cpp:497: warning: ‘d’ is used uninitialized in this function

Comment 1

[Andreas Gal :gal]

Attachment: shutup gcc (might me a tiny overhead, but its not a really relevant path)

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 386780 [details] [diff] [review]
shutup gcc (might me a tiny overhead, but its not a really relevant path)

>diff --git a/js/src/jsxdrapi.cpp b/js/src/jsxdrapi.cpp

> JS_PUBLIC_API(JSBool)
> JS_XDRDouble(JSXDRState *xdr, jsdouble **dpp)
> {
>     jsdouble d;
> 
>-    if (xdr->mode == JSXDR_ENCODE)
>-        d = **dpp;
>+    d = (xdr->mode == JSXDR_ENCODE) ? **dpp : 0.0;

>       case JSVAL_DOUBLE: {
>         jsdouble *dp;
>-        if (xdr->mode == JSXDR_ENCODE)
>-            dp = JSVAL_TO_DOUBLE(*vp);
>+        dp = (xdr->mode == JSXDR_ENCODE) ? JSVAL_TO_DOUBLE(*vp) : NULL;
>         if (!JS_XDRDouble(xdr, &dp))

Unify declaration and assignment while you're here.

Comment 3

[Andreas Gal :gal]

Pushed with the nit above addressed.

http://hg.mozilla.org/tracemonkey/rev/9cb0da88df44

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/9cb0da88df44