502428 - Double-click open folder twisty starts editing current selected item in folders selector

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[bwsilverbolt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5 (.NET CLR 3.5.30729)

It is possible to accidentally rename the "Bookmarks Menu" or "Unsorted Bookmarks" folders by double-clicking the close-tree button of another folder (possibly related to Bug 492061).

Reproducible: Always

Steps to Reproduce:
1. Go to any page.
2. Click on the star in the location bar to bookmark it.
3. Click on the star again to open the "Edit This Bookmark" menu.
4. Click on the "Show all the bookmark folders" button.
5. Scroll down and select either "Bookmarks Menu" or "Unsorted Bookmarks"
6. With the selected folder still in view, click on the plus sign ("+") next to some other bookmark folder to expand it (scroll down all the way again if it pushes the selected folder out of view).
7. Double-click the minus ("-") sign on that folder.
Actual Results:  
The entry will now be renamable.

Expected Results:  
Both the "Bookmarks Menu" and "Unsorted Bookmarks" folders should not be renamable.

If you've ever done this accidentally, it can be frustrating figuring out how to undo it (for some time, my Booksmark Menu folder was called 'foto', the name of one of my other folders).

Comment 1

[Marco Bonardo [:mak]]

I can confirm this.

The "double click on twisty edit selected bookmark" should have been fixed in bug 402655, but looks like it works for a closed twisty not for an open one (can't see how).
There's still an open bug 474720 about the fact one can edit roots names in this dialog.

Comment 2

[Marco Bonardo [:mak]]

I can't reproduce anymore
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110502 Firefox/6.0a1