502458 - Crash [@XPCNativeWrapper::GetNewOrUsed] with Adblock Plus 1.1 installed

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Wladimir Palant]

Firefox 3.0.12 nightlies crash reproducibly on startup if the current Adblock Plus 1.1 development build is installed (https://adblockplus.org/devbuilds/). Crash reports:

http://crash-stats.mozilla.com/report/index/4bba2fe6-c281-423e-87c4-7ab7f2090705
http://crash-stats.mozilla.com/report/index/f19ba8d9-5446-40d8-9963-63ac02090705
http://crash-stats.mozilla.com/report/index/58171c91-7550-4055-b38e-ecb922090705

Firefox 3.0.11 doesn't exhibit this behavior. Looking at the recent changes, this is likely fallout from bug 460882 (which I cannot link to). Given that Adblock Plus 1.1 is supposed to be released in about a week, requesting blocking-1.9.0.12.

Comment 1

[Samuel Sidler (old account; do not CC)]

Blake: Can you take a look at this ASAP? If it's a regression in this cycle, we probably need to fix it now. We were hoping to hand off to build in ~9 hours though...

Comment 2

[Daniel Veditz [:dveditz]]

Wladimir: Bug 460882 landed the evening of June 23 -- do you see this regress between the nightlies of 20090623 and 20090624?

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

This "regressed" as a result of bug 460882 landing on the 1.9.0 branch. It only regressed because bug 455633 hasn't landed on that branch. I can backport that fix if you want...

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

The fix for bug 455633 should fix this everywhere. Wladimir, please test with tomorrow's nightly!

Comment 5

[Wladimir Palant]

The nightly isn't out yet so I tested the hourly builds - 1246856700 (05-Jul-2009 23:32) still crashes while 1246861980 (06-Jul-2009 00:53) doesn't. Thanks, seems to be fixed!

Comment 6

[Al Billings [:abillings - ex-MoCo]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.12pre) Gecko/2009070606 GranParadiso/3.0.12pre (.NET CLR 3.5.30729).