502469 - Captions of narrow preview images look bad when zoomed

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[fcp]

Currently, when a user clicks on a preview image (thumbnail), the image is shown in a highlighted box with its caption.  The width of the box is determined from the width of the image.  This looks bad when the width of the image is small and the caption is longer than a few words.

This is reproducible in AMO 5.0.6 and the upcoming AMO 5.0.7 (previews.addons.mozilla.org).

The highlighted box should have a certain minimum width.  When the image is narrower than this minimum width, the image should be centered horizontally in the box.

The minimum width could be specified simply by the number of pixels (e.g. 200px or 300px), but perhaps a better way would be to specify it by some percentage relative to the width of the window (if it is possible).

Comment 1

[Milos Dinic [:Milos]]

Reproducable on linux x86_64. The problem is that image and description divs are separate. We could fix that buy just putting them in one div.

Comment 2

[Fred Wenzel [:wenzel]]

I couldn't find an add-on to reproduce this.

Comment 3

[fcp]

(In reply to comment #2)
> I couldn't find an add-on to reproduce this.

See the last image at
https://preview.addons.mozilla.org/en-US/firefox/addon/12312

Comment 4

[Fred Wenzel [:wenzel]]

Thanks. I gave it a min-width of 350 pixels. r56057.

Comment 5

[fcp]

Verified fixed on preview.  Thanks!

Comment 6

[Justin Scott [:fligtar]]

This bug was pushed live off-cycle tonight.