502482 - error while syncing bookmarks from server

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[sunjayc99]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
Build Identifier: 0.4

When I try to sync data with the server using firefox 3.5 on Windows Vista 64bit, the sync window syncs everything fine up until "Bookmarks", at which point the progress bar stops moving.
Checking the activity log reveals this:

2009-07-05 12:58:24	Async.Generator      ERROR	Exception: Unknown places item object type

2009-07-05 12:58:24	Async.Generator      ERROR	Exception caught from onComplete handler of CryptoWrap__decrypt-307 generator

2009-07-05 12:58:24	Async.Generator      DEBUG	Async stack trace:

2009-07-05 12:58:24	Async.Generator      ERROR	Exception: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [IWeaveCrypto.decrypt] (JS frame :: file:///C:/Users/sunjayc99/AppData/Roaming/Mozilla/Firefox/Profiles/r6ps9m11.default/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/base_records/crypto.js :: CryptoWrap__decrypt :: line 116)

Reproducible: Always

Steps to Reproduce:
1. Install Firefox 3.5 and Weave 0.4
2. Sign in and sync bookmarks
Actual Results:  
Progress bar does not move; sync wheel in corner of browser spins indefinitely
No bookmarks are synced

Expected Results:  
Bookmarks should sync

Comment 1

[Michael Granger]

I'm experiencing the same problem. I've tried uninstalling the extension, removing the `weave` directory from my profile, and removing all `extensions.weave.*` items from my prefs, and then reinstalling, but to no avail.

Disabling bookmark syncing is a temporary workaround -- it syncs everything else successfully.

Comment 2

[Michael Granger]

By the way, I'm using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5 and Weave 0.4.

Comment 3

[u350879]

I have the same issue.
I use Firefox 3.5 and Weave 0.4.

2009-07-06 14:10:31     Async.Generator      ERROR      Exception: Unknown
places item object type
2009-07-06 14:10:31     Async.Generator      ERROR      Exception caught from
onComplete handler of CryptoWrap__decrypt-102 generator
2009-07-06 14:10:31     Async.Generator      ERROR      Exception: Component
returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[IWeaveCrypto.decrypt] (JS frame ::
file:///C:/Documents%20and%20Settings/sbilbeau/Application%20Data/Mozilla/Firefox/Profiles/hmyusf6f.default/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/base_records/crypto.js
:: CryptoWrap__decrypt :: line 116)

Comment 4

[Ed Lee :Mardak]

Could you check in your brief log to see if you have a warning (on any machine). One of these two messages:

Don't know how to serialize dynamic containers yet
Unknown item type, cannot serialize: ###

If so, we have a good idea on how to fix this.

Comment 5

[Michael Granger]

The word 'serialize' doesn't appear at all in either the brief or verbose logs. I'd be happy to either send my log via personal email or post a scrubbed version if it would help.

Comment 6

[sunjayc99]

I don't know how or why, but everything seems to be working again for me.
Bookmarks are syncing again.

Comment 7

[u350879]

Same for me. 
The word 'serialize' doesn't appear in my log.

Comment 8

[Ed Lee :Mardak]

Could somebody seeing the "Unknown places item type" message edit their weave add-on..

<profile directory>/extensions/{340c2bbc-ce74-4362-90b5-7c26312808ef}/modules/type_records/bookmark.js

On line 82, change..
throw "Unknown places item object type"; 

to..
throw "Unknown places item object type " + JSON.stringify([this]);

Comment 9

[Michael Granger]

(with my username replaced with '<username>'):

2009-07-06 17:31:20	Async.Generator      ERROR	Exception: Unknown places item object type [{"data":{"id":"{f89eedda-be79-4041-bdde-4c83142aa24c}0","parentid":"menu","modified":1246899670,"depth":1,"sortindex":0,"payload":{"encryption":"https://sj-weave01.services.mozilla.com/0.3/user/<username>/crypto/bookmarks","ciphertext":"vhdwABQDS6GiCT5N+cR/G3I9rxjLdEeIYhvIrUGhUOdYDPgFotqYNzfKOxCnSB4phnmaHZoYw6eP36t/MLZ7efo47a/5g7pPcBFbCk4ThZ+oNA5G/egKOeNW012N3cJ9WQo3VcnmiN5vgFQAb6Iqm1r7wVpO3uad0azQClaa0Qc0XcVDBUqhMEeo0K4eObs6m71JkRf7OZvyHLNU/pTnie595tetlQCD78WnhchHvRHBs56Dp43ryNlGCo/Lo+9aZ3fidTbSqjfvjTnTt29Of4uMUQBNB6BDrHjAjOZJfVbElWqWccx63aIeD6ruJuFerobqOTisLShijvy/EOLUpBNNTwQMNihAjkvKmMKferNHTvNAvu4/nFaXOP5pQeLg"}},"cleartext":{},"baseUri":{"query":"full=1&sort=depthindex","spec":"https://sj-weave01.services.mozilla.com/0.3/user/<username>/bookmarks/?full=1&sort=depthindex","prePath":"https://sj-weave01.services.mozilla.com","scheme":"https","userPass":"","username":"","password":"","hostPort":"sj-weave01.services.mozilla.com","host":"sj-weave01.services.mozilla.com","port":-1,"path":"/0.3/user/<username>/bookmarks/?full=1&sort=depthindex","asciiSpec":"https://sj-weave01.services.mozilla.com/0.3/user/<username>/bookmarks/?full=1&sort=depthindex","asciiHost":"sj-weave01.services.mozilla.com","originCharset":"UTF-8","filePath":"/0.3/user/<username>/bookmarks/","param":"","ref":"","directory":"/0.3/user/<username>/bookmarks/","fileName":"","fileBaseName":"","fileExtension":""}}]
2009-07-06 17:31:20	Async.Generator      ERROR	Exception caught from onComplete handler of CryptoWrap__decrypt-62 generator
2009-07-06 17:31:20	Async.Generator      ERROR	Exception: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [IWeaveCrypto.unwrapSymmetricKey] (JS frame :: file:///Users/<username>/Library/Application%20Support/Firefox/Profiles/l64zvzb3.FF31/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/base_records/crypto.js :: CryptoMeta__getKey :: line 178)

Comment 10

[u350879]

My log :

2009-07-07 09:09:17	Async.Generator      ERROR	Exception: Unknown places item object type[{"data":{"id":"{c8f79bf9-567f-40e9-b730-4a28f75eee16}5","parentid":"menu","modified":1246638620,"depth":1,"sortindex":0,"payload":{"encryption":"https://sj-weave01.services.mozilla.com/0.3/user/USERNAME/crypto/bookmarks","ciphertext":"zkHxY2v3fVM9WvSfUNRWD4QWWqJMzOP8Lgl9d49yPDudtn1g6PO91y4nPfOcIAvKQI9R6GfxufoHMCpr2KcGTsLmvkOu6DmvLml3LzNe6c+ppsXS2UWzz05UiYC3OjHgyQpNcDTZMmMTusKH9ArdulZDUjgSdyHLMo8Fr9JR1OZGj9dFeIHVBcu/PDA8BWnd+gPNno4sBrKIG6exFULQC/Iz7pmBWfo5e42QxGCYi5Ki/2QeYX6XSJDXfnpE8x/7+YPXgfzuUj2siEvR3XTY108JW+EdRg90PHVrsMnRF6GT8wHo805MyOvPPuS0kLWTdBK8kNMDvZ1PEyu9FeCdZw8v84SAfNly6MjYCEkYQJUGdTqQnqWhnznVsenLDbIF"}},"cleartext":{},"baseUri":{"query":"newer=1246610730&modified=1246610730&full=1&sort=depthindex","spec":"https://sj-weave01.services.mozilla.com/0.3/user/USERNAME/bookmarks/?newer=1246610730&modified=1246610730&full=1&sort=depthindex","prePath":"https://sj-weave01.services.mozilla.com","scheme":"https","userPass":"","username":"","password":"","hostPort":"sj-weave01.services.mozilla.com","host":"sj-weave01.services.mozilla.com","port":-1,"path":"/0.3/user/USERNAME/bookmarks/?newer=1246610730&modified=1246610730&full=1&sort=depthindex","asciiSpec":"https://sj-weave01.services.mozilla.com/0.3/user/USERNAME/bookmarks/?newer=1246610730&modified=1246610730&full=1&sort=depthindex","asciiHost":"sj-weave01.services.mozilla.com","originCharset":"UTF-8","filePath":"/0.3/user/USERNAME/bookmarks/","param":"","ref":"","directory":"/0.3/user/USERNAME/bookmarks/","fileName":"","fileBaseName":"","fileExtension":""}}]

2009-07-07 09:09:17	Async.Generator      ERROR	Exception caught from onComplete handler of CryptoWrap__decrypt-102 generator

2009-07-07 09:09:17	Async.Generator      ERROR	Exception: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [IWeaveCrypto.decrypt] (JS frame :: file:///C:/Documents%20and%20Settings/sbilbeau/Application%20Data/Mozilla/Firefox/Profiles/hmyusf6f.default/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/base_records/crypto.js :: CryptoWrap__decrypt :: line 116)

Comment 11

[Ed Lee :Mardak]

Thanks for the logs. Some reason cleartext is {} but ciphertext isn't null.. One of the two should always be null.

Could you add above line 60 (// Convert the abstract places item to the actual object type), just below the function(ret) {..

if (this.type == null) throw JSON.stringify([ret, this]);

So it should look like..

CryptoWrapper.prototype.decrypt.call(this, Utils.bind2(this, function(ret) {
  if (this.type == null) throw JSON.stringify([ret, this]);
  // Convert the abstract places item to the actual object type
  if (!this.deleted)
    this.__proto__ = this.getTypeObject(this.type).prototype;

Comment 12

[Ed Lee :Mardak]

I'm guessing the JSON.stringify([ret, this]) will result in [{}, {...}]

Oh wait, this might be easier...

sebastian, go to Tools -> Error Console and clear the entries and paste the following into the box next to Evaluate (near the top) and press enter:
Components.classes["@mozilla.org/browser/nav-bookmarks-service;1"].getService(Components.interfaces.nsINavBookmarksService).getItemIdForGUID("{c8f79bf9-567f-40e9-b730-4a28f75eee16}5")

Similarly for michael, do that except use..
Components.classes["@mozilla.org/browser/nav-bookmarks-service;1"].getService(Components.interfaces.nsINavBookmarksService).getItemIdForGUID("{f89eedda-be79-4041-bdde-4c83142aa24c}0")

That will probably be -1, but if it's not..

Comment 13

[u350879]

The result is 202 in the Eerror Console ...

I have add this line in the bookmar.js :
if (this.type == null) throw JSON.stringify([ret, this]);

The error message disappeared, but the sync does not work ...

2009-07-07 10:15:43	Engine.Clients       INFO	0 outgoing items pre-reconciliation
2009-07-07 10:15:40	Window               INFO	Login successful
2009-07-07 10:15:37	Window               INFO	Logging in...
2009-07-07 10:15:37	Service.Main         INFO	Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1) Gecko/20090624 Firefox/3.5 (.NET CLR 3.5.30729)
2009-07-07 10:15:37	Service.Main         INFO	Weave 0.4.0 initializing
2009-07-07 10:14:33	Engine.Bookmarks     WARN	Sync failed
2009-07-07 10:14:32	Engine.Bookmarks     INFO	4 outgoing items pre-reconciliation

Comment 14

[Ed Lee :Mardak]

Let's just try a plain error message then. Check in your Error Console to see it

if (this.type == null) Cu.reportError(JSON.stringify([ret, this]));

> CryptoWrapper.prototype.decrypt.call(this, Utils.bind2(this, function(ret) {
>   if (this.type == null) Cu.reportError(JSON.stringify([ret, this]));
>   // Convert the abstract places item to the actual object type
>   if (!this.deleted)
>     this.__proto__ = this.getTypeObject(this.type).prototype;

Comment 15

[u350879]

I have change :
if (this.type == null) throw JSON.stringify([ret, this]);

by :
if (this.type == null) Cu.reportError(JSON.stringify([ret, this]));

And the result in my Error Console is the same : 202


But since this morning (in France), the error log is different :

2009-07-08 11:12:03	Service.Main         WARN	Some engines did not sync correctly
2009-07-08 11:12:03	Engine.Passwords     WARN	Sync failed
2009-07-08 11:12:03	Engine.Passwords     INFO	Applied 0 records, reconciled 0 records
2009-07-08 11:12:02	Engine.Passwords     INFO	91 outgoing items pre-reconciliation
2009-07-08 11:12:02	Engine.Passwords     INFO	First sync, uploading all items

Comment 16

[Ed Lee :Mardak]

Attachment: v1

Set the item type for generic PlacesItems, but don't do anything when trying to create it.

Comment 17

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/88c64a878340
Doesn't fix the problem, but it should help debugging to differentiate if it's just trying to sync a PlacesItem or something else.

Leaving open..

Comment 18

[Ed Lee :Mardak]

0.5pre1 is now available, so could you try installing that and see if you run into this "error while syncing bookmarks"? Could you keep an eye on the Brief Activity Log for Warnings or Errors? Thanks!

Comment 19

[u350879]

Ok, where I can download this version of weave ?

Comment 20

[Ed Lee :Mardak]

https://people.mozilla.com/~cbeard/weave/dist/weave-latest.xpi

Comment 21

[Ed Lee :Mardak]

When you update, it's going to wipe the server and do a "first sync". Pay attention to the Brief Log to see if there are any warnings about serializing.

If you _don't_ see any warnings, you might still end up with the error. If you _do_ see warnings, you should see some messages on the other machine's verbose log with a message like "got a generic places item.. do nothing?" when syncing bookmarks.

Comment 22

[u350879]

I have install Weave version 0.5pre1 on two personnal computers. During the first sync, I did not see error or warning message in the "Activity Log".

Now everything works on my 2 computers.

Do you think the issue is fixed? 	
Or it's due to the reset of data on the server after install this new version? 

PS : sorry for my bad english ...

Comment 23

[Dan Mills [:thunder]]

Comment on attachment 387774 [details] [diff] [review]
v1

I think we should warn if we get a generic item down from the server.

Maybe also warn if we're creating one?

Otherwise r+

Comment 24

[Dan Mills [:thunder]]

We think this bug is now fixed.  Please reopen if you still see it.

Comment 25

[Ryan Sutherland]

I too am getting the error "Sync Failed (undefined)" after reinstalling firefox/weave following a hard drive wipe. I've tried some of the fixes, but am getting nothing to work.

Comment 27

[Tony Chung [:tchung]]

Verified fix in weave 1.3b5.  standard smoketest level test.