Closed Bug 502501 Opened 15 years ago Closed 15 years ago

Rename History ▸ Recently Closed Tabs ▸ Open All in Tabs to Restore All Tabs

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6b1

People

(Reporter: adelfino, Assigned: navinjlal)

References

Details

(Keywords: polish, Whiteboard: [good first bug])

Attachments

(1 file, 2 obsolete files)

Rename Open All in Tabs to Restore All Tabs
2.54 KB, patch
faaborg
: ui-review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090705 Minefield/3.6a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090705 Minefield/3.6a1pre

This is to follow History ► Recently Closed Windows ► Restore All Windows. It makes sense to phrase the sentence this way, since restoring the tabs is a more appropriate description for the action.

Reproducible: Always
Version: unspecified → Trunk
Summary: Rename History ► Recently Closed Tabs ► Open All in Tabs to Restore All Tabs → Rename History ▸ Recently Closed Tabs ▸ Open All in Tabs to Restore All Tabs
Status: UNCONFIRMED → NEW
Component: General → Menus
Ever confirmed: true
QA Contact: general → menus
Keywords: polish
Whiteboard: [good first bug]

        Attachment #393584 -
        Flags: review?

    
  

        Attachment #393584 -
        Flags: review? → review?(adelfino)

    
    

    
  
Hi Navin, you need add two new strings for this, i.e. menuRestoreAllTabs.label and menuRestoreAllTabs.accesskey, and then use them here: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-places.js#652

This will make menuOpenAllInTabs.accesskey unused, so it can be removed.

        Attachment #393584 -
        Flags: review?(adelfino)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        restore_all_tabs [updated] (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #393584 -
        Attachment is obsolete: true

        Attachment #393633 -
        Flags: review?

    
  

        Attachment #393633 -
        Attachment description: hopefully this fixes it, it seemed to work after a quick test → restore_all_tabs [updated]

    
  

        Attachment #393633 -
        Flags: review? → review?(dao)

    
    

    
  
Comment on attachment 393633 [details] [diff] [review]
restore_all_tabs [updated]

> # History menu
> menuOpenAllInTabs.label=Open All in Tabs
>-menuOpenAllInTabs.accesskey=o
>+menuRestoreAllTabs.label=Restore All Tabs
>+menuRestoreAllTabs.accesskey=R

The "History menu" comment isn't correct for menuOpenAllInTabs.label anymore.

Maybe just move it down:

> menuOpenAllInTabs.label=Open All in Tabs
> 
> # History menu
> menuRestoreAllTabs.label=Restore All Tabs
> menuRestoreAllTabs.accesskey=R

        Attachment #393633 -
        Flags: ui-review?(faaborg)

        Attachment #393633 -
        Flags: review?(dao)

        Attachment #393633 -
        Flags: review+

    
    

    
  
Is there any way to edit the patch or do I have to submit a new one?

    
    

    
  
You need to submit a new one.

    
    

    
  
(In reply to comment #4)
> > menuOpenAllInTabs.label=Open All in Tabs
> >-menuOpenAllInTabs.accesskey=o
> >+menuRestoreAllTabs.label=Restore All Tabs
> >+menuRestoreAllTabs.accesskey=R
> 
> The "History menu" comment isn't correct for menuOpenAllInTabs.label anymore.

As I can see it isn't used on another place. Why we cannot just remove it?
Assignee: nobody → navinjlal
Status: NEW → ASSIGNED

    
    

    
  
I missed the pop-up. Thanks.

    
    

    
  


  

        Attachment #393633 -
        Attachment is obsolete: true

        Attachment #393912 -
        Flags: review?

        Attachment #393633 -
        Flags: ui-review?(faaborg)

    
  

        Attachment #393912 -
        Flags: review? → ui-review?(faaborg)

    
    

    
  
Comment on attachment 393912 [details] [diff] [review]
Rename Open All in Tabs to Restore All Tabs

Yep this is great, especially since form information will be restored as well (assuming they weren't on an https connection).

        Attachment #393912 -
        Flags: ui-review?(faaborg) → ui-review+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/425a7c8b476a

Thanks Navin!
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6b1

    
    

    
  
It was my pleasure.  Thanks for the assistance.

    
    

    
  
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090812 Minefield/3.6a2pre ID:20090812031634
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: