Cannot use file picker to browse for folders on Windows CE

VERIFIED FIXED

Status

()

Core
Widget: Win32
P4
normal
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Dolske, Assigned: zpao)

Tracking

Trunk
ARM
Windows CE
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nv])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
The "Browse" button on the General prefs pane (for selecting a download location) does nothing on Windows CE. Clicking it should bring up a file picker for selecting a download folder.

I think this might not be implemented in the widget code... widget/src/windows/nsFilePicker.cpp ::ShowW() has a block at the top for "if (mMode == modeGetFolder)", which is #ifdef's out for WinCE. I suspect this is what's used for picking a folder, but didn't verify that.
(Reporter)

Updated

9 years ago
Whiteboard: [nv]
Priority: -- → P4
I'm testing something right now, but basically it looks like you're right... Specifically we use functions and structs with a W at the end, which can be taken off for CE and work (I think).

That's not specific to here. I'm not sure why we do this, but somebody with more Windows programming experience could probably say.
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32
Summary: Options -> General -> Browse button does nothing on Windows CE → Cannot use file picker to browse for folders on Windows CE
Created attachment 388352 [details] [diff] [review]
Patch v0.1

Works. I don't know where else we do it, but you can test it in Options -> General -> Browse
Assignee: nobody → paul
Taras tested on winmo & it doesn't build there. So it looks like instead of getting rid of the #ifndefs I'll just change them to #ifndef WINCE_WINDOWS_MOBILE
Yep, as per:

http://msdn.microsoft.com/en-us/library/aa923860.aspx

not supported on Windows Mobile.

(WinMo is actually based on CE5, not CE6, at least until they unify with CE7)
Created attachment 388513 [details] [diff] [review]
Patch v0.2

I played with the other #ifdefs but no luck. It was just additional error handling, so oh well.
Attachment #388352 - Attachment is obsolete: true
Attachment #388513 - Flags: review?(vladimir)
pushed http://hg.mozilla.org/mozilla-central/rev/b11fc38bb6ae
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 7

9 years ago
Verified fix on Mozilla/5.0 (Windows; U; WindowsCE 6.0; en-US; rv:1.9.2.a2pre)
Gecko/20090818 Namaroka/3.6a2pre.   The textarea for the download location is still transparent, instead of showing up white though.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.