502559 - Find better label for {Insert > Break Below Images} which inserts <br clear="all">

Status: NEW

(Thunderbird :: Message Compose Window, enhancement)

Description

[Stefan Plewako [:stef]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1) Gecko/20090624 Firefox/3.5
Build Identifier: 

Insert → Break Below Images inserts line breaks (< br >), we should change corresponding strings to sth like insert → line break.

Reproducible: Always

Comment 1

[Stefan Plewako [:stef]]

Attachment: proposed patch

Comment 2

[Stefan Plewako [:stef]]

(In reply to comment #1)
This should also resolve bug 320114.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 386951 [details] [diff] [review]
proposed patch

If you want to get this reviewed, you need to add someone's email into the review field. For future reference the list of people is here: https://developer.mozilla.org/en/comm-central#Requirements

As I'm here, I'll put in a couple of people for you.

Comment 4

[[e-mail]]

(In reply to comment #0)
> Insert - Break Below Images inserts line breaks (< br >)
<br clear="all">, which is the whole point.

Comment 5

[Stefan Plewako [:stef]]

(In reply to comment #4)
That's way I'm asking for a label change.

Comment 6

[[e-mail]]

But it's not an ordinary <br>, so Insert - Line Break is misleading too.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 386951 [details] [diff] [review]
proposed patch

Cancelling sr whilst discussion of which text to use is happening - please re-request when ready.

Comment 8

[Stefan Plewako [:stef]]

(In reply to comment #6)
Start new, full width line?

Comment 9

[[e-mail]]

Bryan, can you think of some better wording?

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

In a more page based layout we'd usually call that a "page break" but that doesn't seem right here.  Will try to think of some alternatives.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 386951 [details] [diff] [review]
proposed patch

Cancelling review request whilst we're trying to work out better wording.

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Haven't really come across great changes, "Insert - Clearing Line Break" is about the only change I have but I'm hoping there is something better.

Comment 13

[Thomas D. (:thomas8)]

Wow, that's a menu which I've never seen or tried before...

And yes, the current label/caption ("Break below Images") isn't very good (nor the current summary of this bug > tweaking). It's also not easy to find something better.