If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Shell DomainObject::getClass() does not search entire domain chain

VERIFIED FIXED in flash10.1

Status

Tamarin
Tools
P3
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Michael Daumling, Assigned: Lars T Hansen)

Tracking

unspecified
flash10.1

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 386961 [details] [diff] [review]
Fix that uses the DOmainObject's local DomainEnv

Above method uses the domain found in Shell's CodeContext, and ignores the domain chain created by the DomainObject itself.
Attachment #386961 - Flags: superreview?(stejohns)
Attachment #386961 - Flags: review?(lhansen)

Comment 1

8 years ago
I'll have to do some poking in the Flash codebase to ensure this change is compatible there.

Comment 2

8 years ago
OK, it appears that DomainClass.cpp is not used by Flash or AIR, only avmshell, so no risk of breakage there.
(Assignee)

Updated

8 years ago
Attachment #386961 - Flags: review?(lhansen) → review?(edwsmith)
(Assignee)

Comment 3

8 years ago
Comment on attachment 386961 [details] [diff] [review]
Fix that uses the DOmainObject's local DomainEnv

I'm not competent; forwarding to Edwin.
(Reporter)

Updated

8 years ago
Blocks: 490622

Comment 4

8 years ago
Comment on attachment 386961 [details] [diff] [review]
Fix that uses the DOmainObject's local DomainEnv

the old code was using the caller's domain to begin the search, but i agree that's not right.  getClass() is an instance method and should look in that domain's table.

Domain.currentDomain() is already available for getting the caller's domain.

please add some comments to this effect.

I concur that this is shell-only code.
Attachment #386961 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 5

8 years ago
If this is approved and ready to go we should land it.  sr open to stejohns.
Priority: -- → P3
Target Milestone: --- → flash10.1

Comment 6

8 years ago
Comment on attachment 386961 [details] [diff] [review]
Fix that uses the DOmainObject's local DomainEnv

land that sucker.
Attachment #386961 - Flags: superreview?(stejohns) → superreview+
(Assignee)

Updated

8 years ago
Assignee: daumling → lhansen
(Assignee)

Comment 7

8 years ago
redux changeset:   2729:31beadd17dba
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.