502570 - Shell DomainObject::getClass() does not search entire domain chain

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect, P3)

Description

[Michael Daumling]

Attachment: Fix that uses the DOmainObject's local DomainEnv

Above method uses the domain found in Shell's CodeContext, and ignores the domain chain created by the DomainObject itself.

Comment 1

[Steven Johnson]

I'll have to do some poking in the Flash codebase to ensure this change is compatible there.

Comment 2

[Steven Johnson]

OK, it appears that DomainClass.cpp is not used by Flash or AIR, only avmshell, so no risk of breakage there.

Comment 3

[Lars T Hansen]

Comment on attachment 386961 [details] [diff] [review]
Fix that uses the DOmainObject's local DomainEnv

I'm not competent; forwarding to Edwin.

Comment 4

[Edwin Smith]

Comment on attachment 386961 [details] [diff] [review]
Fix that uses the DOmainObject's local DomainEnv

the old code was using the caller's domain to begin the search, but i agree that's not right.  getClass() is an instance method and should look in that domain's table.

Domain.currentDomain() is already available for getting the caller's domain.

please add some comments to this effect.

I concur that this is shell-only code.

Comment 5

[Lars T Hansen]

If this is approved and ready to go we should land it.  sr open to stejohns.

Comment 6

[Steven Johnson]

Comment on attachment 386961 [details] [diff] [review]
Fix that uses the DOmainObject's local DomainEnv

land that sucker.

Comment 7

[Lars T Hansen]

redux changeset:   2729:31beadd17dba