Closed
Bug 502682
Opened 16 years ago
Closed 16 years ago
CheckIfVotedConfirmed fails to confirm a bug if you don't have the permissions to set status/everconfirmed
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: mkanat, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.16 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Because we now use set_status and set_everconfirmed in CheckIfVotedConfirmed, if your vote confirms a bug but you aren't in editbugs, the change will actually fail.
Flags: blocking3.4+
Flags: blocking3.2.4+
|
Assignee | |
Updated•16 years ago
|
|
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #387034 -
Flags: review?(mkanat)
|
|
Reporter | |
Updated•16 years ago
|
Attachment #387034 -
Flags: review?(mkanat) → review+
|
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 387034 [details] [diff] [review]
patch, v1
Yeah, this is a fine hack for now.
Eventually we'll have add_vote, and when a vote confirms a bug, we can call a confirm_by_vote method or something, that sets up something so that set_status and set_everconfirmed can bypass security checks.
|
|
Reporter | |
Updated•16 years ago
|
Flags: approval3.4+
Flags: approval3.2+
Flags: approval+
|
|
Assignee | |
Comment 3•16 years ago
|
||
tip:
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.282; previous revision: 1.281
done
3.3.4:
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.276.2.6; previous revision: 1.276.2.5
done
3.2.3:
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.241.2.20; previous revision: 1.241.2.19
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: testcase?
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•