MobileNightlyRepackFactory doesn't clobber ever

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: aki, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

10 years ago
Not sure what I expected it to do.

BaseRepackFactory has a hardcoded |rm -rf dist/upload| and |rm -rf dist/update| but MobileNightlyRepackFactory just scp's a glob from dist/.  When the binaries change names, it uploads the old+new.

Move BaseRepackFactory's rm commands to an addPreCleanSteps() method and override in MobileNightlyRepackFactory.

Comment 1

10 years ago
The glob upload doesn't work all to well anyway, I'm adding an l10n-upload-% target as part of bug 490482 to use upload.py instead and given package names.

Patch there should be ready soon.

Not sure how much we actually have in dist/upload or dist/update in the Firefox case, I read the build logs to upload from dist and dist/install. Coop, Armen?
(Assignee)

Comment 2

10 years ago
Fixed in bug 511889 for reasons only known to myself.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.