50279 - importxml.pl is missing in list of executable files in checksetup.pl (Fix included)

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Eric Maryniak]

In file checksetup.pl the Perl script importxml.pl is missing in
the list of files which need to be marked executable.
In line #436 is should be added to 'my @executable_files':

# These are the files which need to be marked executable
my @executable_files =
   ('processmail', 'whineatnews.pl', 'collectstats.pl', 'checksetup.pl',
    'syncshadowdb', 'importxml.pl');

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch to add importxml.pl to the list of executable files

Comment 2

[Dave Miller [:justdave]]

There may be more missing that are needed here...  I see a few other .pl files in 
there, too...  not sure if they need to be executable or not.  (I believe they 
only need to be executable if they're being called from the shell...  if they are 
run by another perl script, they don't need to be).  Then again, those could 
always be their own bugs, too.

Comment 3

[Stephan Niemz]

Yet another bug which has a very simple patch attached and should be closed
IMHO instead of being moved to 2.16 or whatever. Renominating for 2.12.

Patch looks good to me (r=me for what it's worth).

Comment 4

[Dave Miller [:justdave]]

taking...

Comment 5

[Dave Miller [:justdave]]

Checked in.

Comment 6

[Tara Hernandez]

Sorry for the spam, but I needed to be able to query for all of these correctly.

Comment 7

[Gervase Markham [:gerv]]

Dave: Did you ever make sure all executable files were in that list?

Gerv

Comment 8

[Dave Miller [:justdave]]

yes, there's been other bugs filed on executables missing from the list since 
this one.  The one in this bug has been taken care of.  I'd say verify it, but I 
probably shouldn't be the one to do it since I'm the one that marked it Fixed.

Comment 9

[Matthew Tuck [:CodeMachine]]

Verified on my local install checksetup.pl sets correct permissions on
importxml.pl.

Comment 10

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product