importxml.pl is missing in list of executable files in checksetup.pl (Fix included)

VERIFIED FIXED in Bugzilla 2.12

Status

()

P3
minor
VERIFIED FIXED
19 years ago
6 years ago

People

(Reporter: e.maryniak, Assigned: justdave)

Tracking

unspecified
Bugzilla 2.12

Details

(Whiteboard: 2.12, URL)

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
In file checksetup.pl the Perl script importxml.pl is missing in
the list of files which need to be marked executable.
In line #436 is should be added to 'my @executable_files':

# These are the files which need to be marked executable
my @executable_files =
   ('processmail', 'whineatnews.pl', 'collectstats.pl', 'checksetup.pl',
    'syncshadowdb', 'importxml.pl');
Created attachment 23089 [details] [diff] [review]
Patch to add importxml.pl to the list of executable files
There may be more missing that are needed here...  I see a few other .pl files in 
there, too...  not sure if they need to be executable or not.  (I believe they 
only need to be executable if they're being called from the shell...  if they are 
run by another perl script, they don't need to be).  Then again, those could 
always be their own bugs, too.
Keywords: patch, review
Whiteboard: 2.14

Updated

18 years ago
Whiteboard: 2.14 → 2.16

Comment 3

18 years ago
Yet another bug which has a very simple patch attached and should be closed
IMHO instead of being moved to 2.16 or whatever. Renominating for 2.12.

Patch looks good to me (r=me for what it's worth).
Whiteboard: 2.16 → 2.12
taking...
Assignee: tara → dave
Checked in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
Sorry for the spam, but I needed to be able to query for all of these correctly.
Target Milestone: --- → Bugzilla 2.12
Dave: Did you ever make sure all executable files were in that list?

Gerv
yes, there's been other bugs filed on executables missing from the list since 
this one.  The one in this bug has been taken care of.  I'd say verify it, but I 
probably shouldn't be the one to do it since I'm the one that marked it Fixed.
Verified on my local install checksetup.pl sets correct permissions on
importxml.pl.
Status: RESOLVED → VERIFIED
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.