502970 - add iterate_vars() convenience method to dehydra.js

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[[e-mail]]

Attachment: patch + test

Comment 1

[[e-mail]]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/4e6f9a956004

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 387338 [details] [diff] [review]
patch + test

>+    for each(let va in v.assign)
>+    for each (ret in var_iter(va))
>+    yield ret

What's with the lack of indentation (and semicolon, for that matter)?

Also, space before ( after each in second line but not on first nit.

Bug: missing let makes ret a global var!

>+
>+    for each(let vp in v.arguments)
>+    for each (ret in var_iter(vp))
>+    yield ret
>+
>+    for each (let vi in v.inits)
>+    for each (ret in var_iter(vi))
>+    yield ret
>   }

etc.

/be

Comment 3

[[e-mail]]

Thanks for comments - tweaks pushed as http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/583e9896d0ec.