remove effectively-dead code that sets the host in the status bar's security button

RESOLVED FIXED in Firefox 3.6a1

Status

()

Firefox
General
--
minor
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 3.6a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 387397 [details] [diff] [review]
patch
Attachment #387397 - Flags: review?(gavin.sharp)
Attachment #387397 - Flags: review?(gavin.sharp) → review-
Comment on attachment 387397 [details] [diff] [review]
patch

>diff --git a/browser/base/content/browser.css b/browser/base/content/browser.css

>+/* There's no label for the security UI in the status bar. */
> #security-button > label {

Shouldn't we just change security-button to be a statusbarpanel-iconic rather than a statusbarpanel-iconic-text?

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>+#ifdef DEBUG
>     try {
>       this._host = gBrowser.contentWindow.location.host;
>     } catch(ex) {
>       this._host = null;
>     }
>+#endif

If we're not actually using _host for anything anymore, this code and the debug assertion is useless, right?

>-#security-button {
>-  min-width: 20px;
>-  -moz-box-direction: reverse;
>-}

Why remove these?
(Assignee)

Comment 2

8 years ago
(In reply to comment #1)
> If we're not actually using _host for anything anymore, this code and the debug
> assertion is useless, right?

It seems to verify that _hostChanged is correctly false. The early return doesn't only affect the host, but also the rest of the UI.

> >-#security-button {
> >-  min-width: 20px;
> >-  -moz-box-direction: reverse;
> >-}
> 
> Why remove these?

DOMi says the width exceeds 20px anyway, and box-direction:reverse makes sense only if there's a label.
(Assignee)

Comment 3

8 years ago
Created attachment 387667 [details] [diff] [review]
patch v2

using statusbarpanel-iconic now. I'm indifferent about the debug code.
Attachment #387397 - Attachment is obsolete: true
Attachment #387667 - Flags: review?(gavin.sharp)
Comment on attachment 387667 [details] [diff] [review]
patch v2

(In reply to comment #2)
> It seems to verify that _hostChanged is correctly false. The early return
> doesn't only affect the host, but also the rest of the UI.

Good point! Doesn't hurt to keep it I guess.
Attachment #387667 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/2acc8c5989ae
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1

Updated

7 years ago
Duplicate of this bug: 493010
You need to log in before you can comment on or make changes to this bug.