503029 - remove effectively-dead code that sets the host in the status bar's security button

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 387397 [details] [diff] [review]
patch

>diff --git a/browser/base/content/browser.css b/browser/base/content/browser.css

>+/* There's no label for the security UI in the status bar. */
> #security-button > label {

Shouldn't we just change security-button to be a statusbarpanel-iconic rather than a statusbarpanel-iconic-text?

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>+#ifdef DEBUG
>     try {
>       this._host = gBrowser.contentWindow.location.host;
>     } catch(ex) {
>       this._host = null;
>     }
>+#endif

If we're not actually using _host for anything anymore, this code and the debug assertion is useless, right?

>-#security-button {
>-  min-width: 20px;
>-  -moz-box-direction: reverse;
>-}

Why remove these?

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> If we're not actually using _host for anything anymore, this code and the debug
> assertion is useless, right?

It seems to verify that _hostChanged is correctly false. The early return doesn't only affect the host, but also the rest of the UI.

> >-#security-button {
> >-  min-width: 20px;
> >-  -moz-box-direction: reverse;
> >-}
> 
> Why remove these?

DOMi says the width exceeds 20px anyway, and box-direction:reverse makes sense only if there's a label.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch v2

using statusbarpanel-iconic now. I'm indifferent about the debug code.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 387667 [details] [diff] [review]
patch v2

(In reply to comment #2)
> It seems to verify that _hostChanged is correctly false. The early return
> doesn't only affect the host, but also the rest of the UI.

Good point! Doesn't hurt to keep it I guess.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/2acc8c5989ae