Closed Bug 503036 Opened 11 years ago Closed 4 years ago

spare closebutton="true" attribute on tabs element

Categories

(SeaMonkey :: Tabbed Browser, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.46

People

(Reporter: dao, Assigned: medka_15)

Details

Attachments

(1 file)

/suite/browser/tabbrowser.xml
    * line 104 -- <xul:tabs class="tabbrowser-tabs" closebutton="true" flex="1"

closebutton="true" doesn't do anything in this case. It should be removed. See also bug 500971.
Attached patch ahmed2.patchSplinter Review
Added patch, please review.
Attachment #8696350 - Flags: review?(dao)
Attachment #8696350 - Flags: review?(dao) → review?(philip.chee)
Comment on attachment 8696350 [details] [diff] [review]
ahmed2.patch

Thanks for your patch. Sorry for the delay.
> Removed at line 104: closebutton="true" doesn't do anything in this case.
Please add the bug number to your commit message e.g.

Bug 503036 Remove closebutton="true" from tabbrowser.xml since it doesn't do anything.
Attachment #8696350 - Flags: review?(philip.chee) → review+
http://hg.mozilla.org/comm-central/rev/15f73b93ee2d
Assignee: nobody → medka_15
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.46
You need to log in before you can comment on or make changes to this bug.