VMPI/MMgcPortWin.cpp and WinPortUtils are producing warning C4640 when compiling with the player

VERIFIED FIXED

Status

Tamarin
Garbage Collection (mmGC)
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Brent Baker, Unassigned)

Tracking

unspecified
x86
Windows XP
Bug Flags:
flashplayer-qrb +
flashplayer-triage +

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 387423 [details] [diff] [review]
Fixes for c4640 warning

This causes problems if you try and compile with warnings as errors.

VMPI\MMgcPortWin.cpp(492) : warning C4640: 'dbgHelpLock' : construction of local static object is not thread-safe

VMPI\WinPortUtils.cpp(62) : warning C4640: 'gTimeZoneInfoLock' : construction of local static object is not thread-safe

Moving the static member outside of the InitDbHelp() and UpdateTimeZoneInfo() fixes the error (recommended by Lars)
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Attachment #387423 - Flags: review?(lhansen)
(Reporter)

Comment 1

9 years ago
This bug is currently a blocking issue for the successful compilation of FRR

Comment 2

9 years ago
Comment on attachment 387423 [details] [diff] [review]
Fixes for c4640 warning

Please place a comment above each of the two moved lines to the effect that they're not inside the function because that triggers that specific compiler warning.
Attachment #387423 - Flags: review?(lhansen) → review+
(Reporter)

Comment 3

9 years ago
Added comment and pushed 2107:cbd25c20e6a1
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: flashplayer-qrb? → flashplayer-qrb+
Resolution: --- → FIXED

Comment 4

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.