Changing ARM architecture requires editing header file

VERIFIED FIXED in flash10.1

Status

Tamarin
Baseline JIT (CodegenLIR)
P3
normal
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Tom Donovan, Assigned: Rick Reitmaier)

Tracking

({arch})

unspecified
flash10.1
ARM
Linux
Bug Flags:
flashplayer-triage +

Details

Attachments

(1 attachment)

395 bytes, patch
Rick Reitmaier
: review+
Edwin Smith
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/530.5 (KHTML, like Gecko) Chrome/2.0.172.33 Safari/530.5
Build Identifier: tamarin-redux 1.4 2009-07-08 

It is currently necessary to edit nanojit/NativeARM.h to generate ARMv6 or ARMv7 instructions instead of ARMv5 instructions. This should be a compile-time option.

Reproducible: Always
(Reporter)

Comment 1

9 years ago
Created attachment 387460 [details] [diff] [review]
proposed patch
(Reporter)

Updated

9 years ago
Keywords: arch
Hardware: Other → ARM

Comment 2

9 years ago
Whatever approach we use here, let's surface it to nanojit clients as well; knowing we are ARMv6-or-later would allow other optimizations elsewhere (eg unaligned reads).

Comment 3

8 years ago
Tom needs this in the next TC merge.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: flashplayer-triage+
Flags: flashplayer-qrb?

Updated

8 years ago
Attachment #387460 - Flags: review?(rreitmai)
(Assignee)

Updated

8 years ago
Attachment #387460 - Flags: review?(rreitmai) → review+

Updated

8 years ago
Assignee: nobody → rreitmai
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → flash10.1

Updated

8 years ago
Attachment #387460 - Flags: superreview?(edwsmith)

Comment 4

8 years ago
Can someone push this for Tom?

Updated

8 years ago
Attachment #387460 - Flags: superreview?(edwsmith) → superreview+

Comment 5

8 years ago
pushed to redux as changeset:   2363:1925894aa227
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 6

8 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED

Comment 7

8 years ago
removing QRB request, bug verified
Flags: flashplayer-qrb?
You need to log in before you can comment on or make changes to this bug.