503137 - xpcshell.exe needs an --environ cli option to work with xpcshell unittests on windows mobile

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: xpcshell --environ

We found that the xpcshell unit tests require a cwd which does not exist on windows mobile.  Through various other patches in bug 458950 we have support for --environ:CWD=<path> for fennec.

This support is needed when running xpcshell.exe, not just fennec.exe or xulrunner.exe.  I have a patch that WFM during my testing last night.  This uses nsWindowsWMain.cpp as a shell around main to handle the --environ argument.
I would think my approach for envp is not ideal as it was a quick and dirty hack.

Comment 1

[Jeff Walden [:Waldo]]

xpcshell bugs are xpconnect bugs, not JS engine bugs.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: just a little clean up

perhaps we want to add a call to the shunt to generate an envp in the future, but I don't think it should block on that

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: actually cleaned up patch

sorry, attached the wrong patch

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 387940 [details] [diff] [review]
actually cleaned up patch

I would like to state for the record: uh EW!

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/722ddfcba374

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8fca26f09b16