Closed Bug 503137 Opened 11 years ago Closed 11 years ago

xpcshell.exe needs an --environ cli option to work with xpcshell unittests on windows mobile

Categories

(Core :: XPConnect, defect)

ARM
Windows Mobile 6 Professional
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: jmaher, Assigned: blassey)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch xpcshell --environ (obsolete) — Splinter Review
We found that the xpcshell unit tests require a cwd which does not exist on windows mobile.  Through various other patches in bug 458950 we have support for --environ:CWD=<path> for fennec.

This support is needed when running xpcshell.exe, not just fennec.exe or xulrunner.exe.  I have a patch that WFM during my testing last night.  This uses nsWindowsWMain.cpp as a shell around main to handle the --environ argument.
I would think my approach for envp is not ideal as it was a quick and dirty hack.
xpcshell bugs are xpconnect bugs, not JS engine bugs.
Assignee: general → nobody
Component: JavaScript Engine → XPConnect
QA Contact: general → xpconnect
Attached patch just a little clean up (obsolete) — Splinter Review
perhaps we want to add a call to the shunt to generate an envp in the future, but I don't think it should block on that
Attachment #387492 - Attachment is obsolete: true
Attachment #387939 - Flags: review?
Attachment #387939 - Flags: review? → review?(mrbkap)
sorry, attached the wrong patch
Attachment #387939 - Attachment is obsolete: true
Attachment #387940 - Flags: review?(mrbkap)
Attachment #387939 - Flags: review?(mrbkap)
Comment on attachment 387940 [details] [diff] [review]
actually cleaned up patch

I would like to state for the record: uh EW!
Attachment #387940 - Flags: superreview+
Attachment #387940 - Flags: review?(mrbkap)
Attachment #387940 - Flags: review+
pushed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #387940 - Flags: approval1.9.2?
Attachment #387940 - Flags: approval1.9.2? → approval1.9.2+
Blocks: 491903
Assignee: nobody → blassey.bugs
You need to log in before you can comment on or make changes to this bug.