default sans serif font on Windows CE shouldn't be Times

VERIFIED FIXED

Status

()

VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Dolske, Assigned: vlad)

Tracking

Trunk
ARM
Windows CE
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nv])

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
The Windows CE device we're testing with doesn't have Arial installed (the usual Windows-default sans font), but does have Tahoma. Gecko seems to choose Times New Roman as the default sans font, which doesn't look right at all.

Also odd is that in the default font selector (Prefs, Content -> Advanced), the list has:

Proportional: Serif   16
Serif: times new roman [sic, no caps]
Sans-serif: courier new
Monospace: courier new  13

But the displayed sans font clearly isn't Courier.
(Reporter)

Updated

9 years ago
Whiteboard: [nv]
Created attachment 388396 [details] [diff] [review]
#define this based on OS

This works for now; eventually we'll want to probably just set it to bitstream vera sans, if/when we ship with the vera fonts.
Assignee: nobody → vladimir
Attachment #388396 - Flags: review?
Attachment #388396 - Flags: review? → review?(jdaggett)

Updated

9 years ago
Summary: default sans serif font on Windows CE shouldn't be Times → default sans serif font on Windows CE shouldn't be Arial

Comment 2

9 years ago
Comment on attachment 388396 [details] [diff] [review]
#define this based on OS

Looks fine.
Attachment #388396 - Flags: review?(jdaggett) → review+
Actually, times was correct in the description -- there is no Arial on the device, and so we fall back to the first font in the global system list, which happened to be Times :-)
Summary: default sans serif font on Windows CE shouldn't be Arial → default sans serif font on Windows CE shouldn't be Times
http://hg.mozilla.org/mozilla-central/rev/8c6278b0f782
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Updated

9 years ago
Blocks: 504675
Comment on attachment 388396 [details] [diff] [review]
#define this based on OS

>-pref("font.name-list.cursive.he", "Guttman Yad, Ktav, Arial");
>+#expand pref("font.name-list.cursive.he", "Guttman Yad, Ktav, " __WINDOWS_SANS_SERIF_FONT__);

Does this actually work?  (It didn't seem to in my quick test.)
(Reporter)

Comment 6

9 years ago
Nope! We actually ran into this and tracked it down just a few minutes before your comment, checking in a patch shortly.
(Reporter)

Comment 7

9 years ago
Created attachment 389066 [details] [diff] [review]
Bustage fix

Bustage fix for the above.

I tried just inserting a plus, so the output was pref("foo", "bar"+"baz"), but the browser didn't seem to like that either.

So this just removes the quotes from the #defines, and moves them into the prefs.

EG, instead of
  #define BAR "bar" 
  pref("foo", BAR);

it's now
  #define BAR bar
  pref("foo", "BAR");

Comment 9

9 years ago
(In reply to comment #7)
> I tried just inserting a plus, so the output was pref("foo", "bar"+"baz"), but
> the browser didn't seem to like that either.
We stopped parsing pref files using the JS engine a long time ago, ironically to make it faster on mobile devices! (Bug 98533, if you're interested.)
Verified fix on Mozilla/5.0 (Windows; U; WindowsCE 6.0; en-US; rv:1.9.2.a2pre)
Gecko/20090818 Namaroka/3.6a2pre.  Default font is: Times New Roman, size 16
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.