503148 - AUS needs more configurable throttling

Status: RESOLVED FIXED

(AUS Graveyard :: Administration, task)

Description

[[e-mail] (:bhearsum)]

During the time that both 3.0.x and 3.5.x are active branches we need the ability to control throttling more easily and finely. Specifically, we need to support the following:
* 3.0.x -> 3.5.x needs to throttled sometimes, and unthrottled other times. Ideally, configurable per channel with fallbacks obeying that.

Morgamic threw out a couple of ideas over IRC, I'll let him comment on those.

Comment 1

[[e-mail] (:bhearsum)]

It would be great to get this fixed before we ship 3.0.12 to beta (July 14th), but we can live without for longer if necessary.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #1)
> It would be great to get this fixed before we ship 3.0.12 to beta (July 14th),
> but we can live without for longer if necessary.

aiui, the "workaround" would be to disable major update offer for FF3.0.11 users, so I'd hope to not go that way if we have a choice. :-(

Morgamic: I remember we talked about this before the release, but now I cant remember the details... what are some of the ideas you had for this? Anything we can do to help?

Comment 3

[Michael Morgan [:morgamic]]

Couple of weeks ago we realized that per-channel wasn't going to work since to do that explicitly we'd have to enter 1200+ channels per version.

An alternative could be just adding regular expression and/or wildcard support to what we had prior to the patch in bug 500794, which made it stupider.

So what we really need is a mostly per-version (haha) config that whitelists channels and makes the same behavior trickle-down to partners.

A config like that would look like what we had in 500794, but we could just define channels to never throttle in the global config, if that's the path of least resistance.

Of course, long-term it makes sense to rethink this entire system, rewrite it and create a relational database to store these relationships properly -- but until then there are 2 or 3 ways we can define this logic in the config.

Comment 4

[[e-mail] (:bhearsum)]

Morgamic and I talked through this a bit more. He proposed keeping the per version throttling, but also allowing a per-channel override that accepts regular expressions. So when we ship 3.0.12 to beta tomorrow we can configure AUS to unthrottle the beta, test channels, and relevant partner channels.

Is that an accurate summary, Mike?

Comment 5

[Michael Morgan [:morgamic]]

Attachment: v1, first crack at adding exceptions

This adds channel exceptions, based on regular expressions.  Not based on product, and it's global.  I think this is what we want, but if we have cases where we have different behavior per channel for different products and versions we can change it.

Comment 6

[Michael Morgan [:morgamic]]

Attachment: v2, patch that is version specific

more granular, but I don't believe it is needed

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 388420 [details] [diff] [review]
v2, patch that is version specific

I tested this on aus2-staging (with telnet), and it worked as intended.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

This landed in CVS on 2009-07-14.