Closed
Bug 503160
Opened 16 years ago
Closed 16 years ago
integer constants are not automatically demoted
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sayrer, Assigned: sayrer)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files, 3 obsolete files)
|
5.18 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
|
1.86 KB,
application/x-javascript
|
Details |
shows up in some peacekeeper benchmarks
|
Assignee | |
Updated•16 years ago
|
Summary: needlessly inserting quads into arrays → integer constants are not automatically demoted
|
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: general → sayrer
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #390018 -
Flags: review?(gal)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 390018 [details] [diff] [review]
refactored
Not sure my original code was ever reviewed. Probably better to get dvander to stamp it too. Otherwise I am approving my own stuff here :)
Attachment #390018 -
Flags: review?(gal)
Attachment #390018 -
Flags: review?(dvander)
Attachment #390018 -
Flags: review+
|
|
||
Updated•16 years ago
|
Attachment #390018 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 390018 [details] [diff] [review]
refactored
>+
>+static JSBool FASTCALL
>+dense_grow(JSContext* cx, JSObject* obj, jsint i, jsval v)
this should have been inline. says Shark.
>+ if (JS_LIKELY(INT_FITS_IN_JSVAL(j)))
>+ v = INT_TO_JSVAL(j);
>+ else {
style fail!
|
|
Assignee | |
Comment 5•16 years ago
|
||
Attachment #390005 -
Attachment is obsolete: true
Attachment #390018 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•16 years ago
|
||
Attachment #390107 -
Attachment is obsolete: true
Attachment #390109 -
Flags: review?(gal)
|
|
||
Updated•16 years ago
|
Attachment #390109 -
Flags: review?(gal) → review+
|
|
Assignee | |
Comment 7•16 years ago
|
||
|
|
Assignee | |
Comment 8•16 years ago
|
||
Comment on attachment 390109 [details] [diff] [review]
nit fixed, inlined
SS, v8 no change or slightly faster (< 3-4ms)
|
|
Assignee | |
Comment 9•16 years ago
|
||
Flags: wanted1.9.2+
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 10•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•