Closed Bug 503195 Opened 11 years ago Closed 11 years ago

Using Places nodes' PropertyBags leaks

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mak, Assigned: mak)

Details

Attachments

(1 file, 3 obsolete files)

I was playing with them, and noticed we don't handle them during cycle collection.
Attached patch patch v1.0 (obsolete) — Splinter Review
Attachment #387571 - Flags: review?(dietrich)
Comment on attachment 387571 [details] [diff] [review]
patch v1.0

>+ * The Initial Developer of the Original Code is Mozilla Corporation
nit: new line for company name

>+function run_test() {
nit: { on newline

>+  try {
>+    rootNode.propertyBag.getProperty("testProperty");
>+    do_throw("Found property in the propertyBag after removing it");
>+  } catch(ex) {}
nit: catch on newline

>+  rootNode.containerOpen = false;
>+  try {
>+    rootNode.propertyBag.getProperty("testProperty");
>+    do_throw("Found property in the propertyBag after removing it");
>+  } catch(ex) {}
ditto

r=sdwilsh
Attachment #387571 - Flags: review?(dietrich) → review+
Attached patch patch v1.1 (obsolete) — Splinter Review
Attachment #387571 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/307f15cf7ff2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
for some unknown reason this did compile here, but does not compile on tinderboxes, backed out.
http://hg.mozilla.org/mozilla-central/rev/75393a766e00
http://hg.mozilla.org/mozilla-central/rev/31a51fa6ce76
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch patch v1.2 (obsolete) — Splinter Review
i missed a pointer
Attachment #387613 - Attachment is obsolete: true
Attached patch patch v1.2Splinter Review
Attachment #387623 - Attachment is obsolete: true
re-pushed
http://hg.mozilla.org/mozilla-central/rev/0d2fc193cd1f
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.