503195 - Using Places nodes' PropertyBags leaks

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

I was playing with them, and noticed we don't handle them during cycle collection.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 387571 [details] [diff] [review]
patch v1.0

>+ * The Initial Developer of the Original Code is Mozilla Corporation
nit: new line for company name

>+function run_test() {
nit: { on newline

>+  try {
>+    rootNode.propertyBag.getProperty("testProperty");
>+    do_throw("Found property in the propertyBag after removing it");
>+  } catch(ex) {}
nit: catch on newline

>+  rootNode.containerOpen = false;
>+  try {
>+    rootNode.propertyBag.getProperty("testProperty");
>+    do_throw("Found property in the propertyBag after removing it");
>+  } catch(ex) {}
ditto

r=sdwilsh

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/307f15cf7ff2

Comment 5

[Marco Bonardo [:mak]]

for some unknown reason this did compile here, but does not compile on tinderboxes, backed out.
http://hg.mozilla.org/mozilla-central/rev/75393a766e00
http://hg.mozilla.org/mozilla-central/rev/31a51fa6ce76

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.2

i missed a pointer

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch v1.2

Comment 8

[Marco Bonardo [:mak]]

re-pushed
http://hg.mozilla.org/mozilla-central/rev/0d2fc193cd1f