If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[arm]: hitting bogus assertion in nPatchBranch

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nv])

Attachments

(1 attachment)

Created attachment 387561 [details] [diff] [review]
fix the branch patch call

We're hitting this assertion in nPatchBranch, which is no longer valid -- we may have written a PC-relative branch in JMP_far (if 0 happened to be close to where we allocated our code block) that we then need to rewrite as a long branch in nPatchBranch.  Just remove the assertion and write the right code in here.
Attachment #387561 - Flags: review?
Whiteboard: [nv]
Comment on attachment 387561 [details] [diff] [review]
fix the branch patch call

r=crashfix :p
Attachment #387561 - Flags: review? → review+
http://hg.mozilla.org/mozilla-central/rev/d74bb87029cd
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Does this affect the tracemonkey tree too? (It didn't when I tested it
... on the current tip just now.)
You need to log in before you can comment on or make changes to this bug.