503279 - Fix "missing initializer" GCC warnings in gfx

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[timeless]

gfx/qcms/transform.c: In function ‘adaption_matrix’:
506: warning: missing initializer
506: warning: (near initialization for ‘lam_rigg.invalid’)

Comment 1

[timeless]

Attachment: patch

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I don't really see the point in this warning. I'd rather accept a patch that disables -Wmissing-field-initializers for qcms. Cairo also has a bunch of warnings like this, so it should also be compiled without -Wmissing-field-initializers.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: fix: disable warning in qcms, cairo/cairo, cairo/libpixman

This patch disables the warning in three gfx subdirectories.

There are currently (before this patch) 61 instances of the warning in gfx/cairo/cairo/, 5 in gfx/cairo/libpixman/, and 1 in gfx/qcms/.  (That covers all the instances of this warning within gfx)

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: fix: disable warning in qcms, cairo/cairo, cairo/libpixman

sorry, should have used CFLAGS, not COMPILE_CFLAGS. (both work, but IIUC, COMPILE_CFLAGS is a superset of the CFLAGS, and just tweaking CFLAGS is sufficient)

Fixed here.

Comment 6

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/9c9440d8eee7