Fix issues found from the small-screen theme

RESOLVED FIXED in fennec1.0b3

Status

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Trunk
fennec1.0b3
ARM
Windows Mobile 6 Professional

Details

Attachments

(2 attachments, 1 obsolete attachment)

Followup from bug 475356:

* Bookmarklist Header is not the same size as the URLBar header, so a small visual shift happens. I think this is related to the size of non-image toolbarbuttons (the "Manage: one in this case)
* Move the "fullscreen" close buttons up a little
(Assignee)

Comment 1

10 years ago
* Add fresh images from Sean Martell
tracking-fennec: --- → 1.0b1-wm+

Comment 2

10 years ago
Created attachment 388868 [details]
Fennec updated smaller PNG set - wince

resized PNGs for wince attached.
(Assignee)

Comment 3

10 years ago
Patch coming up
Assignee: nobody → mark.finkle
(Assignee)

Comment 4

10 years ago
Created attachment 389004 [details] [diff] [review]
WIP 1

* Updated the images from martell
* Added folder-24.png to css and jar.mn

I still want to fix the other 2 issues before asking for review
(Assignee)

Comment 5

10 years ago
Created attachment 389191 [details] [diff] [review]
patch

This patch fixes the bookmark list header by adding a CSS media query to platform.css for toolbarbutton min-height and min-width. I did not add platform-low.css and platfrom-high.css files as this seemed overkill for now.

The patch also moves up the fullscreen buttons 1 pixel - hey it made a difference.
Attachment #389004 - Attachment is obsolete: true
Attachment #389191 - Flags: review?(gavin.sharp)
(Assignee)

Comment 6

10 years ago
Gavin - the patch is full of images, but those are merely replacements for existing images. The CSS files do have some tweaks though.
Attachment #389191 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 7

10 years ago
pushed: http://hg.mozilla.org/mobile-browser/rev/7b225708b6fe
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → B3

Updated

9 years ago
Component: Windows Mobile → General
OS: Windows XP → Windows Mobile 6 Professional
QA Contact: mobile-windows → general
Hardware: x86 → ARM
You need to log in before you can comment on or make changes to this bug.