Closed Bug 503388 Opened 13 years ago Closed 13 years ago

Fix issues found from the small-screen theme

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Windows Mobile 6 Professional
defect
Not set
normal

Tracking

(fennec1.0b1-wm+)

RESOLVED FIXED
fennec1.0b3
Tracking Status
fennec 1.0b1-wm+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(2 files, 1 obsolete file)

Followup from bug 475356:

* Bookmarklist Header is not the same size as the URLBar header, so a small visual shift happens. I think this is related to the size of non-image toolbarbuttons (the "Manage: one in this case)
* Move the "fullscreen" close buttons up a little
* Add fresh images from Sean Martell
tracking-fennec: --- → 1.0b1-wm+
resized PNGs for wince attached.
Patch coming up
Assignee: nobody → mark.finkle
Attached patch WIP 1 (obsolete) — Splinter Review
* Updated the images from martell
* Added folder-24.png to css and jar.mn

I still want to fix the other 2 issues before asking for review
Attached patch patchSplinter Review
This patch fixes the bookmark list header by adding a CSS media query to platform.css for toolbarbutton min-height and min-width. I did not add platform-low.css and platfrom-high.css files as this seemed overkill for now.

The patch also moves up the fullscreen buttons 1 pixel - hey it made a difference.
Attachment #389004 - Attachment is obsolete: true
Attachment #389191 - Flags: review?(gavin.sharp)
Gavin - the patch is full of images, but those are merely replacements for existing images. The CSS files do have some tweaks though.
Attachment #389191 - Flags: review?(gavin.sharp) → review+
pushed: http://hg.mozilla.org/mobile-browser/rev/7b225708b6fe
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → B3
Component: Windows Mobile → General
OS: Windows XP → Windows Mobile 6 Professional
QA Contact: mobile-windows → general
Hardware: x86 → ARM
You need to log in before you can comment on or make changes to this bug.