503388 - Fix issues found from the small-screen theme

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Followup from bug 475356:

* Bookmarklist Header is not the same size as the URLBar header, so a small visual shift happens. I think this is related to the size of non-image toolbarbuttons (the "Manage: one in this case)
* Move the "fullscreen" close buttons up a little

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

* Add fresh images from Sean Martell

Comment 2

[Sean Martell]

Attachment: Fennec updated smaller PNG set - wince

resized PNGs for wince attached.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Patch coming up

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: WIP 1

* Updated the images from martell
* Added folder-24.png to css and jar.mn

I still want to fix the other 2 issues before asking for review

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch fixes the bookmark list header by adding a CSS media query to platform.css for toolbarbutton min-height and min-width. I did not add platform-low.css and platfrom-high.css files as this seemed overkill for now.

The patch also moves up the fullscreen buttons 1 pixel - hey it made a difference.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Gavin - the patch is full of images, but those are merely replacements for existing images. The CSS files do have some tweaks though.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: http://hg.mozilla.org/mobile-browser/rev/7b225708b6fe