503395 - Advanced Search dropdown displays on top of contents in IE7

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[raymond [:retornam] (inactive)]

In IE7 when you click on Advanced Search the drop down displays on top of already existing content

http://screencast.com/t/KlykEfh3

Comment 1

[Jeff Balogh (:jbalogh)]

I'm tempted to wontfix this since it doesn't affect usability and the A-grade support doc says "Minor inconsistencies between browsers is tolerable".

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: search dropdown had float issues since we had a primary without a secondary

...but since this is my day for that curious curse of ours, here's a patch.  The page had a class=primary without a class=secondary, so floats weren't getting cleared in the expected manner.  Removing class=primary and changing the selectors to use [role=main] maintains the current styling while fixing the bug.

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 387769 [details] [diff] [review]
 search dropdown had float issues since we had a primary without a secondary

It doesn't break for me so I'll r+.  I didn't think attribute selector support was all that widespread but quirksmode.org says I'm old and dumb.

I'm r?ing rdoherty just the same.

Comment 4

[Ryan Doherty (:rdoherty)]

Comment on attachment 387769 [details] [diff] [review]
 search dropdown had float issues since we had a primary without a secondary

wfm.

Comment 5

[Jeff Balogh (:jbalogh)]

r29604.  Thanks for double-teaming that, guys.

Comment 6

[raymond [:retornam] (inactive)]

https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:72 verified fixed