503425 - [qmo2] Ordered list missing number prefix

Status: VERIFIED FIXED

(quality.mozilla.org :: Website, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When you are using ordered list in documents the numbering is not visible. I'm able to see this at least on quality.authstage.mozilla.com.

Use something like this in the richtext editor:

1. First item
2. Second item

Comment 1

[Paul Craciunoiu [:paulc]]

r29579 added a bit of CSS.
https://quality.authstage.mozilla.com/blogs/paulc/test-title

Comment 2

[Paul Craciunoiu [:paulc]]

Should test this for regressions on other QMO pages.

Comment 3

[Aakash Desai [:aakashd]]

looks great!! yay, numbered/ordered lists ftw in authstage

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Already mentioned on IRC but also check nested lists.

Comment 5

[Paul Craciunoiu [:paulc]]

Created: https://quality.authstage.mozilla.com/blogs/paulc/test-nested-lists
Looks good.

r29746

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Has something been broken the rich test editor? The toolbar shows both buttons pushed for ul and ol lists when clicking on "item ul nested 1".

Comment 7

[Paul Craciunoiu [:paulc]]

That's probably because of nested lists, you're inside both a ul and ol. Does something not WORK (functionality-wise)?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Try to switch this row into a ul. It will not work. Also creating a new sub ordered list for this item I cannot get to work. Just wanted to add a ol/ul/ol to check if this path also works because it is missing.

Comment 9

[Paul Craciunoiu [:paulc]]

(In reply to comment #8)
> Try to switch this row into a ul. It will not work. Also creating a new sub
> ordered list for this item I cannot get to work. Just wanted to add a ol/ul/ol
> to check if this path also works because it is missing.
That's not related to this bug. This is just how tinymce handles nested lists. I'm sure you can find lots of glitches :)
I made it work by selecting both 'item ul nested 1' and 'item ul nested 2' and unselecting "ul" button, then de-selecting and selecting ol. ... Such are the quirks of tinymce (our richtext editor).

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's true. Ok, so I have updated your test page and noticed that the left indentation is not correct for ordered lists when comparing them to unordered lists. That applies to all levels in the hierarchy.

Comment 11

[Paul Craciunoiu [:paulc]]

Not correct? Can you be more specific?

Comment 12

[Paul Craciunoiu [:paulc]]

Please file a new bug if you want to change the padding. In CSS, however, they use the same padding (20px). I think this is a minor issue and it's not very noticeable (or perhaps I'm missing something). At any rate, it's not about missing the number prefix and therefore out of the scope of this bug. It's better to keep to few commits per bug, to keep track of things easily.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Paul, this is more then obvious to see. Please check your example page. Ordered sub lists show the numbering at the parents level. Which is not a minor issue IMO and can definitely be fixed in this bug because your patch r29746 doesn't take the outside value of the ul property into account. And as far as I can see it hasn't been pushed live yet.

Comment 14

[Paul Craciunoiu [:paulc]]

I don't get it...

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have updated your test page. Check the Test alignment section.

Comment 16

[Aakash Desai [:aakashd]]

Henrik, I don't want to block the push of bugs for the QMO 1.0 milestone because of this minor issue. Please open a new bug and it'll be taken care of in the next one. I'm moving this to resolved:fixed.

Comment 17

[Aakash Desai [:aakashd]]

verified