503476 - Enable javascript shell (js.exe) for Symbian

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Makoto Kato [:m_kato]]

Nokia's OpenC/C++ has console emulator, so js.exe should be enabled on Symbian.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch v1

about build config, I will fix by bug 503344.

Comment 2

[Jim Blandy :jimb]

So the underlying issue here is that Symbian has no sbrk() function?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to comment #2)
> So the underlying issue here is that Symbian has no sbrk() function?

Yes. OpenC/C++ (http://www.forum.nokia.com/Technology_Topics/Development_Platforms/Open_C_and_C++/) has no sbrk() function.

Comment 4

[Jim Blandy :jimb]

Attachment: Bug 503476: Use configure to decide whether to call sbrk.

Makoto, could you try out this patch to see if it addresses the problem?

In general, I'd rather be using autoconf-style tests for this than more platform-specific #ifs.

Comment 5

[Jim Blandy :jimb]

(FWIW, the try servers like that patch.)

Comment 6

[Makoto Kato [:m_kato]]

(In reply to comment #4)
> Created an attachment (id=391181) [details]
> Bug 503476: Use configure to decide whether to call sbrk.
> 
> Makoto, could you try out this patch to see if it addresses the problem?

Good!!.  It works fine!

Comment 7

[Jim Blandy :jimb]

(In reply to comment #6)
> Good!!.  It works fine!

Okay, great.  Let me get some review on that...

Comment 8

[Jim Blandy :jimb]

http://hg.mozilla.org/mozilla-central/rev/b0f135c756bc