Closed Bug 503476 Opened 11 years ago Closed 10 years ago

Enable javascript shell (js.exe) for Symbian

Categories

(Core :: JavaScript Engine, defect)

All
Symbian
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file, 1 obsolete file)

Nokia's OpenC/C++ has console emulator, so js.exe should be enabled on Symbian.
Attached patch patch v1 (obsolete) — Splinter Review
about build config, I will fix by bug 503344.
Attachment #387835 - Flags: review?(jim)
So the underlying issue here is that Symbian has no sbrk() function?
(In reply to comment #2)
> So the underlying issue here is that Symbian has no sbrk() function?

Yes. OpenC/C++ (http://www.forum.nokia.com/Technology_Topics/Development_Platforms/Open_C_and_C++/) has no sbrk() function.
Makoto, could you try out this patch to see if it addresses the problem?

In general, I'd rather be using autoconf-style tests for this than more platform-specific #ifs.
(FWIW, the try servers like that patch.)
(In reply to comment #4)
> Created an attachment (id=391181) [details]
> Bug 503476: Use configure to decide whether to call sbrk.
> 
> Makoto, could you try out this patch to see if it addresses the problem?

Good!!.  It works fine!
Attachment #387835 - Attachment is obsolete: true
Attachment #387835 - Flags: review?(jim)
(In reply to comment #6)
> Good!!.  It works fine!

Okay, great.  Let me get some review on that...
Attachment #391181 - Flags: review?(jorendorff)
Attachment #391181 - Flags: review?(jorendorff) → review+
Whiteboard: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/b0f135c756bc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
You need to log in before you can comment on or make changes to this bug.