Closed Bug 503491 Opened 16 years ago Closed 16 years ago

Right-clicking the “remove this tag” icon removes the tag

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P4)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: fcp2007, Assigned: wenzel)

Details

On the add-on details page, right-clicking the “remove this tag” icon removes the tag if JavaScript is enabled. This is unexpected because right clicks are not supposed to trigger any action immediately. You should almost always check event.button in the onmousedown handler and the like.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → 5.0.8
Priority: -- → P4
Target Milestone: 5.0.8 → Future
Assignee: nobody → cdolivei.bugzilla
That wfm on a Firefox nightly.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
(In reply to comment #1) > That wfm on a Firefox nightly. I tested it with Firefox 3.6b2 and 3.5.5. The bug still almost always reproduces on preview.addons.mozilla.org, but not always. -> reopening Looking at the source code at http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/webroot/js/tags.js?annotate=29581#l44 I cannot see any reason why this bug does not reproduce. Reproducible with: Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.2b2) Gecko/20091108 Firefox/3.6b2 (.NET CLR 3.5.30729) Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I can still reproduce on preview
Status: REOPENED → NEW
It's apparently a problem with jQuery's live() handler: http://stackoverflow.com/questions/1489817/jquery-liveclick-firing-for-right-click The click event is not supposed to fire for right clicks (and it doesn't) but due to the nature of the live() handler implementation, it does in this case. Fixed in r56064. Thanks for filing this, it's a weird bug.
Assignee: a.sacred.line+bugzilla → fwenzel
Status: NEW → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Target Milestone: Future → 5.4
fcp: please take a look on preview when you get a chance? Thanks!
Verified fixed on preview on the same environments as in comment #2. Thanks! (In reply to comment #4) > The click event is not supposed to fire for right clicks I did not know that, thanks for the info! It seems bug 71705. As for the click event on the document object, I found bug 485980, but I am not sure how relevant it is. Anyway checking event.button should not hurt. Thanks again!
Status: RESOLVED → VERIFIED
This bug was pushed live off-cycle tonight.
Target Milestone: 5.4 → 5.3.1
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.