503510 - re-enable esc building on tamarin-redux

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Brent Baker]

Work item #224

In the last TC merge (4/24) the esc build failed. We should be building esc in redux so that we could have tracked when this failure occurred. Why it was removed from tr is unclear.

Comment 1

[Brent Baker]

Attachment: Add esc building back into buildbot on windows

Comment 2

[Brent Baker]

Thinking about this a little more maybe it makes more sense to place the esc into the deep testing since we are not actually recording the compilation time, we just want to make sure that we are able to recompile esc multiple times. 

We could add it to the windows platform now and then add it to the other platforms as they come online.

Comment 3

[Brent Baker]

Attachment: Run esc in windows deep testing

When we add more platforms to deep testing we can add this buildstep to them

Comment 4

[Dan Schaffer]

Comment on attachment 387883 [details] [diff] [review]
Run esc in windows deep testing

the /usr/bin/time -v -o flags are only supported on gnu time (would require some special setup on mac/linux).  as we discussed we could just remove the timing code.

Comment 5

[Brent Baker]

Pushed 2122:c89b4ae23e44

Comment 6

[Brent Baker]

Attachment: Remove the use of time from the script

Remove the tracking of how long esc takes to compile. This is a test to make sure that we can compile esc and is NOT a performance test.

Comment 7

[Brent Baker]

patch v3 pushed as changeset 2134:d1fffa9d6662

Comment 8

[Dan Schaffer]

Attachment: make run-release-esc.sh run cross platform

allows esc to run on non-windows platforms. use ${shell_extension} instead of hard coding .exe.

Comment 9

[Brent Baker]

Comment on attachment 388686 [details] [diff] [review]
make run-release-esc.sh run cross platform

Can remove the second "chmod +x" since the shell has already been made executable on line 70

Comment 10

[Brent Baker]

esc is self compiling in the windows-deep, windows64-deep and mac-ppc-deep builders