503515 - exporting certificates lack an extension

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kevin Brosnan]

Export a cert via options/prefs > advanced > encryption > view certificates > servers > export don't have a file extension. This makes importing the file via the certificate manger harder as it is not detected by the file picker.

If you don't have an exception listed you can add one by visiting https://verisign.com

Comment 1

[Kevin Brosnan]

Attachment: Cert export screenshot

Comment 2

[Kevin Brosnan]

Attachment: Cert import screenshot

Comment 3

[u279076]

in-litmus+
https://litmus.mozilla.org/show_test.cgi?id=6017

This is the actual test case that discovered the bug.

Comment 4

[:Cykesiopka]

Note that on Windows, a .crt extension *is* in fact appended. On my Linux setup, there is no extension appended, as noted in comment 0.

Comment 6

[:Cykesiopka]

Attachment: MozReview Request: Bug 503515 - Try and ensure exported certificates include an extension by default.

Review commit: https://reviewboard.mozilla.org/r/33959/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33959/

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8716853 [details]
MozReview Request: Bug 503515 - Try and ensure exported certificates include an extension by default.

https://reviewboard.mozilla.org/r/33959/#review30727

Sounds good. Just the one question.

::: security/manager/pki/resources/content/pippki.js:93
(Diff revision 1)
> +  fp.init(parent, bundle.getString("SaveCertAs"), nsIFilePicker.modeSave);

My one concern with moving this line is the documentation says the file picker isn't valid until init is called. Should it occur before setting defaultString/Extension?

Comment 8

[:Cykesiopka]

https://reviewboard.mozilla.org/r/33959/#review30727

Thanks for the review!

> My one concern with moving this line is the documentation says the file picker isn't valid until init is called. Should it occur before setting defaultString/Extension?

Good catch - the call to init() should stay where it is. I was reading https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIFilePicker concerning defaultString, and somehow misread "This should be set before calling open() or show()" as "[...] init()"...

Comment 9

[:Cykesiopka]

Attachment: bug503515_extension-by-default-when-export-cert_v2.patch

- Revert move of init() call.

Comment 10

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee91b67bcf6e

The tc[Tier-2](B) failure looks unrelated.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b0ec072cd21

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b0ec072cd21